DevTools: Convert inspector-unit tests to use reusable test harness

third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+TestRunner.executeTestScript = function() {
+  fetch(`${Runtime.queryParam('test')}`)
+      .then((data) => data.text())
+      .then((testScript) => eval(`(function(){${testScript}})()`))
+      .catch((error) => {
+        TestRunner.addResult(`Unable to execute test script because of error: ${error}`);
+        TestRunner.completeTest();
+      });
+};
+
+/** @type {!Array<string>} */
+TestRunner.results = [];

[dgozman, 2016/11/30 18:19:54]

_results ?

[chenwilliam, 2016/11/30 19:53:09]

Done.

+
+/**
+ * @suppressGlobalPropertiesCheck
+ */
+TestRunner.completeTest = function() {
+  if (!self.testRunner) {
+    console.log('Test Done');
+    return;
+  }
+
+  Array.prototype.forEach.call(document.documentElement.childNodes, x => x.remove());
+  var outputElement = document.createElement('div');
+  // Support for svg - add to document, not body, check for style.
+  if (outputElement.style) {
+    outputElement.style.whiteSpace = 'pre';
+    outputElement.style.height = '10px';
+    outputElement.style.overflow = 'hidden';
+  }
+  document.documentElement.appendChild(outputElement);
+  for (var i = 0; i < TestRunner.results.length; i++) {
+    outputElement.appendChild(document.createTextNode(TestRunner.results[i]));
+    outputElement.appendChild(document.createElement('br'));
+  }
+  TestRunner.results = [];
+  testRunner.notifyDone();

[dgozman, 2016/11/30 18:19:54]

nit: self.testRunner

[chenwilliam, 2016/11/30 19:53:09]

Done.

+};
+
+TestRunner.addResult = function(text) {

[dgozman, 2016/11/30 18:19:54]

Let's JSDoc everything, since we are compiling now.

[chenwilliam, 2016/11/30 19:53:08]

Done.

+  if (self.testRunner)
+    TestRunner.results.push(String(text));
+  else
+    console.log(text);
+};
+
+TestRunner.runTests = function(tests) {
+  nextTest();
+
+  function nextTest() {
+    var test = tests.shift();
+    if (!test) {
+      TestRunner.completeTest();
+      return;
+    }
+    TestRunner.addResult('\ntest: ' + test.name);
+    var testPromise = test();
+    if (!(testPromise instanceof Promise))
+      testPromise = Promise.resolve();
+    testPromise.then(nextTest);
+  }
+};
+
+/**
+ * @param {!Object} receiver
+ * @param {string} methodName
+ * @return {!Promise<*>}
+ */
+TestRunner.addSniffer = function(receiver, methodName) {
+  return new Promise(function(resolve, reject) {
+    var original = receiver[methodName];
+    if (typeof original !== 'function') {
+      reject('Cannot find method to override: ' + methodName);
+      return;
+    }
+
+    receiver[methodName] = function(var_args) {
+      try {
+        var result = original.apply(this, arguments);
+      } finally {
+        receiver[methodName] = original;
+      }
+      // In case of exception the override won't be called.
+      try {
+        Array.prototype.push.call(arguments, result);
+        resolve.apply(this, arguments);
+      } catch (e) {
+        reject('Exception in overridden method \'' + methodName + '\': ' + e);
+        TestRunner.completeTest();
+      }
+      return result;
+    };
+  });
+};
+
+/**
+ * @param {!Array<string>} lazyModules
+ * @return {!Promise<!Array<undefined>>}
+ */
+TestRunner.loadLazyModules = function(lazyModules) {
+  return Promise.all(lazyModules.map(lazyModule => self.runtime.loadModulePromise(lazyModule)));
+};
+
+/**
+ * @param {string} key
+ * @param {boolean} ctrlKey
+ * @param {boolean} altKey
+ * @param {boolean} shiftKey
+ * @param {boolean} metaKey
+ * @return {!KeyboardEvent}
+ */
+TestRunner.createKeyEvent = function(key, ctrlKey, altKey, shiftKey, metaKey) {
+  return new KeyboardEvent('keydown', {
+    key: key,
+    bubbles: true,
+    cancelable: true,
+    ctrlKey: ctrlKey,
+    altKey: altKey,
+    shiftKey: shiftKey,
+    metaKey: metaKey
+  });
+};
+
+/**
+ * @param {string|!Event} message
+ * @param {string} source
+ * @param {number} lineno
+ * @param {number} colno
+ * @param {!Error} error
+ */
+function completeTestOnError(message, source, lineno, colno, error) {
+  TestRunner.addResult('TEST ENDED IN ERROR: ' + error.stack);
+  TestRunner.completeTest();
+}
+
+self['onerror'] = completeTestOnError;

[dgozman, 2016/11/30 18:19:54]

Let's wrap this function and assignment into closure.

[chenwilliam, 2016/11/30 19:53:09]

Done.