DevTools: Convert inspector-unit tests to use reusable test harness

third_party/WebKit/Source/devtools/front_end/externs.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 788 matching lines @@
 
 Terminal.prototype = {
   fit: function() {},
   linkify: function() {},
   /** @param {!Element} element */
   open: function(element) {},
   /** @param {string} eventName * @param {!Function} handler */
   on: function(eventName, handler) {}
 };
 
+var testRunner = {};

[einbinder, 2016/11/30 19:51:06]

Can we somehow enforce that this might be undefined? I'm worried about a
situation where someone uses testRunner before checking if it exists, all the
tests on the bots pass, but it breaks devtools or at least the tests outside of
content shell.

[chenwilliam, 2016/11/30 23:06:03]

I moved the type definition into the test_runner module so it's a closure type
error if you use self.testRunner in a production module. It's still possible to
break tests outside of content shell (when we write them in the future) but I
think we can address this later once we have them.

+testRunner.notifyDone = function() {};
+
 // Module namespaces.
 var Accessibility = {};
 var Animation = {};
 var Audits = {};
 var Audits2 = {};
 var Audits2Worker = {};
 var Bindings = {};
 var CmModes = {};
 var Common = {};
 var Components = {};
@@ skipping 14 matching lines @@
 var Persistence = {};
 var Platform = {};
 var Profiler = {};
 var Resources = {};
 var Sass = {};
 var Screencast = {};
 var SDK = {};
 var Security = {};
 var Services = {};
 var Settings = {};
+var Shell = {};
 var Snippets = {};
 var SourceFrame = {};
 var Sources = {};
 var Terminal = {};
+var TestRunner = {};
 var TextEditor = {};
 var Timeline = {};
 var TimelineModel = {};
 var ToolboxBootstrap = {};
 var UI = {};
 var UtilitySharedWorker = {};
 var WorkerService = {};
 var Workspace = {};