Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2513413006: [X87][test]: Fixing -Wsign-compare compilation error for x87 test case. (Closed)

Created:
4 years, 1 month ago by zhengxing.li
Modified:
4 years ago
Reviewers:
ulan, chunyang.dai
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[X87][test]: Fixing -Wsign-compare compilation error for x87 test case. BUG= Committed: https://crrev.com/38092c41c27af5fcd2988adb299cc3a76fcbbf75 Cr-Commit-Position: refs/heads/master@{#41202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/cctest/test-run-wasm-relocation-x87.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-11-22 03:27:56 UTC) #2
ulan
lgtm
4 years, 1 month ago (2016-11-22 09:34:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513413006/1
4 years ago (2016-11-23 06:10:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 06:31:14 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-23 06:31:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38092c41c27af5fcd2988adb299cc3a76fcbbf75
Cr-Commit-Position: refs/heads/master@{#41202}

Powered by Google App Engine
This is Rietveld 408576698