Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2513413002:
[promises] Do not export GlobalPromise (Closed)
Description[promises] Do not export GlobalPromise
This is unused.
BUG=v8:5343
TBR=littledan@chromium.org
Committed: https://crrev.com/5e5e87963f47fa8b791574cb80a96def61daab0b
Cr-Commit-Position: refs/heads/master@{#41148}
Patch Set 1 #
Messages
Total messages: 22 (14 generated)
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [promises] Do not export GlobalPromise BUG=v8:5343 ========== to ========== [promises] Do not export GlobalPromise This is unused. BUG=v8:5343 ==========
gsathya@chromium.org changed reviewers: + littledan@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
gsathya@chromium.org changed reviewers: + neis@chromium.org
lgtm
The CQ bit was checked by gsathya@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/29004)
Description was changed from ========== [promises] Do not export GlobalPromise This is unused. BUG=v8:5343 ========== to ========== [promises] Do not export GlobalPromise This is unused. BUG=v8:5343 TBR=littledan@chromium.org ==========
The CQ bit was checked by gsathya@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479740326601350, "parent_rev":
["ffe7567404a5631011fea6f8d1210cc9e38ac6c5", null], "commit_rev":
["6d12c7b9c31605b44a743265324d9595a70af7b3", null]}
Message was sent while issue was closed.
Description was changed from ========== [promises] Do not export GlobalPromise This is unused. BUG=v8:5343 TBR=littledan@chromium.org ========== to ========== [promises] Do not export GlobalPromise This is unused. BUG=v8:5343 TBR=littledan@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [promises] Do not export GlobalPromise This is unused. BUG=v8:5343 TBR=littledan@chromium.org ========== to ========== [promises] Do not export GlobalPromise This is unused. BUG=v8:5343 TBR=littledan@chromium.org Committed: https://crrev.com/5e5e87963f47fa8b791574cb80a96def61daab0b Cr-Commit-Position: refs/heads/master@{#41148} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5e5e87963f47fa8b791574cb80a96def61daab0b Cr-Commit-Position: refs/heads/master@{#41148} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
