[NTP] Cleanup: offline pages related tests.

components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 124 matching lines @@
 
 void RecentTabSuggestionsProvider::ClearCachedSuggestions(Category category) {
   // Ignored.
 }
 
 void RecentTabSuggestionsProvider::GetDismissedSuggestionsForDebugging(
     Category category,
     const DismissedSuggestionsCallback& callback) {
   DCHECK_EQ(provided_category_, category);
 
-  // TODO(vitaliii): Query all pages instead by using an empty query.
+  // Even not related to recent tab offline pages are queried here, so that

[Marc Treib, 2016/11/21 12:27:53]

Also here: IMO this is hard to parse, maybe
"Offline pages not related to Recent Tabs are also queried here, ..." ?

[vitaliii, 2016/11/21 14:56:46]

Done.
I did it similarly to your comment in DownloadsProvider.

+  // they can be returned in case there are problems with dismissing.
+  OfflinePageModelQueryBuilder query_builder;
   offline_page_model_->GetPagesMatchingQuery(
-      BuildRecentTabsQuery(offline_page_model_),
+      query_builder.Build(offline_page_model_->GetPolicyController()),
       base::Bind(&RecentTabSuggestionsProvider::
                      GetPagesMatchingQueryCallbackForGetDismissedSuggestions,
                  weak_ptr_factory_.GetWeakPtr(), callback));
 }
 
 void RecentTabSuggestionsProvider::ClearDismissedSuggestionsForDebugging(
     Category category) {
   DCHECK_EQ(provided_category_, category);
   StoreDismissedIDsToPrefs(std::set<std::string>());
   FetchRecentTabs();
@@ skipping 138 matching lines @@
 }
 
 void RecentTabSuggestionsProvider::StoreDismissedIDsToPrefs(
     const std::set<std::string>& dismissed_ids) {
   prefs::StoreDismissedIDsToPrefs(pref_service_,
                                   prefs::kDismissedRecentOfflineTabSuggestions,
                                   dismissed_ids);
 }
 
 }  // namespace ntp_snippets