Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: testing/android/native_test/native_test_launcher.cc

Issue 2513363003: repro for crbug.com/663886
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/android/native_test/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/android/native_test/native_test_launcher.cc
diff --git a/testing/android/native_test/native_test_launcher.cc b/testing/android/native_test/native_test_launcher.cc
index a9475d1ae1bdcb87dffc6516491b62734ee6c15b..6473a35f8249409124b69dcbe62c4844d8f6c07f 100644
--- a/testing/android/native_test/native_test_launcher.cc
+++ b/testing/android/native_test/native_test_launcher.cc
@@ -98,8 +98,8 @@ static void RunTests(JNIEnv* env,
// Fully initialize command line with arguments.
base::CommandLine::ForCurrentProcess()->AppendArguments(
base::CommandLine(argc, &argv[0]), false);
- const base::CommandLine& command_line =
- *base::CommandLine::ForCurrentProcess();
+ //const base::CommandLine& command_line =
+ //*base::CommandLine::ForCurrentProcess();
base::FilePath stdout_file_path(
base::android::ConvertJavaStringToUTF8(env, jstdout_file_path));
@@ -121,12 +121,12 @@ static void RunTests(JNIEnv* env,
}
dup2(STDOUT_FILENO, STDERR_FILENO);
- if (command_line.HasSwitch(switches::kWaitForDebugger)) {
- AndroidLog(ANDROID_LOG_VERBOSE,
- "Native test waiting for GDB because flag %s was supplied",
- switches::kWaitForDebugger);
- base::debug::WaitForDebugger(24 * 60 * 60, true);
- }
+ //if (command_line.HasSwitch(switches::kWaitForDebugger)) {
+ //AndroidLog(ANDROID_LOG_VERBOSE,
+ //"Native test waiting for GDB because flag %s was supplied",
+ //switches::kWaitForDebugger);
+ //base::debug::WaitForDebugger(24 * 60 * 60, true);
+ //}
base::FilePath test_data_dir(
base::android::ConvertJavaStringToUTF8(env, jtest_data_dir));
« no previous file with comments | « testing/android/native_test/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698