Remove WTF_ATTRIBUTE_PRINTF.

Remove WTF_ATTRIBUTE_PRINTF.

Use PRINTF_FORMAT defined in base/compiler_specific.h instead.
Also, prepend PRINTF_FORMAT to functions.

https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_Definitions
> Attributes, and macros that expand to attributes, appear at the very beginning
> of the function declaration or definition, before the return type:

BUG=596760
Committed: https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe
Cr-Commit-Position: refs/heads/master@{#433825}

[tkent, 2016-11-21 07:06:31]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 07:06:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-11-21 07:10:39]

Description was changed from

==========
Remove WTF_ATTRIBUTE_PRINTF.

Use PRINTF_FORMAT defined in base/compiler_specific.h.
Also, prepend PRINTF_FORMAT to functions.

https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_D...
> Attributes, and macros that expand to attributes, appear at the very beginning
> of the function declaration or definition, before the return type:

BUG=596760
==========

to

==========
Remove WTF_ATTRIBUTE_PRINTF.

Use PRINTF_FORMAT defined in base/compiler_specific.h instead.
Also, prepend PRINTF_FORMAT to functions.

https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_D...
> Attributes, and macros that expand to attributes, appear at the very beginning
> of the function declaration or definition, before the return type:

BUG=596760
==========

[tkent, 2016-11-21 08:15:16]

tkent@chromium.org changed reviewers:
+ yutak@chromium.org

[tkent, 2016-11-21 08:15:16]

yutak@, would you review this please?

[Yuta Kitamura, 2016-11-21 08:58:39]

https://codereview.chromium.org/2513363002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/Assertions.h (left):

https://codereview.chromium.org/2513363002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Assertions.h:68: #endif
Can you explicitly include base/compiler_specific.h and document
the availability of PRINTF_FORMAT here?

[commit-bot: I haz the power, 2016-11-21 09:08:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 09:08:12]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-11-21 09:12:30]

https://codereview.chromium.org/2513363002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/Assertions.h (left):

https://codereview.chromium.org/2513363002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Assertions.h:68: #endif
On 2016/11/21 at 08:58:39, Yuta Kitamura wrote:
> Can you explicitly include base/compiler_specific.h and document
> the availability of PRINTF_FORMAT here?

The Blink counterpart of base/compiler_specific.h is wtf/Compiler.h.  Should we
include base/compiler_specific.h though this file already includes
wtf/Compiler.h?

[Yuta Kitamura, 2016-11-21 09:27:48]

https://codereview.chromium.org/2513363002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/Assertions.h (left):

https://codereview.chromium.org/2513363002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Assertions.h:68: #endif
On 2016/11/21 09:12:30, tkent wrote:
> On 2016/11/21 at 08:58:39, Yuta Kitamura wrote:
> > Can you explicitly include base/compiler_specific.h and document
> > the availability of PRINTF_FORMAT here?
> 
> The Blink counterpart of base/compiler_specific.h is wtf/Compiler.h.  Should
we
> include base/compiler_specific.h though this file already includes
> wtf/Compiler.h?

That's okay, too.

[tkent, 2016-11-22 00:55:12]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 00:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 01:13:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 01:13:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tkent, 2016-11-22 01:54:53]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2016-11-22 01:55:06]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-11-22 01:55:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-11-22 02:15:18]

https://codereview.chromium.org/2513363002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/Assertions.h (left):

https://codereview.chromium.org/2513363002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/Assertions.h:68: #endif
On 2016/11/21 at 09:27:48, Yuta Kitamura wrote:
> On 2016/11/21 09:12:30, tkent wrote:
> > On 2016/11/21 at 08:58:39, Yuta Kitamura wrote:
> > > Can you explicitly include base/compiler_specific.h and document
> > > the availability of PRINTF_FORMAT here?
> > 
> > The Blink counterpart of base/compiler_specific.h is wtf/Compiler.h.  Should
we
> > include base/compiler_specific.h though this file already includes
> > wtf/Compiler.h?
> 
> That's okay, too.

Uploaded Patch Set 2.

[Yuta Kitamura, 2016-11-22 05:14:17]

On 2016/11/22 02:15:18, tkent wrote:
> 
> Uploaded Patch Set 2.

Sorry I wasn't clear, but I meant adding a comment *in* Compiler.h
telling that PRINTF_FORMAT is available, but not adding a comment
in each include (which looks excessive).

However, Compiler.h already includes everything in
compiler_specific.h (without any comments), so I start to feel
like extra comments in Compiler.h are not needed.

Sorry for extra work, but can you do: Patch Set 1 with correct
includes (including Compiler.h where necessary)?

[commit-bot: I haz the power, 2016-11-22 05:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 05:39:45]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-11-22 06:12:10]

> Sorry for extra work, but can you do: Patch Set 1 with correct
> includes (including Compiler.h where necessary)?

Done.

[Yuta Kitamura, 2016-11-22 06:20:40]

LGTM

[tkent, 2016-11-22 06:24:31]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-11-22 06:24:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 09:31:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479795871742350,
"parent_rev": "d4f3ac0e8fea75aa2f1e0514c8c3f5fbcb27b721", "commit_rev":
"0c5549ae9c4e66b32c9e9b581a7e4d07f7d3d31d"}

[commit-bot: I haz the power, 2016-11-22 09:31:31]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-22 09:33:53]

Description was changed from

==========
Remove WTF_ATTRIBUTE_PRINTF.

Use PRINTF_FORMAT defined in base/compiler_specific.h instead.
Also, prepend PRINTF_FORMAT to functions.

https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_D...
> Attributes, and macros that expand to attributes, appear at the very beginning
> of the function declaration or definition, before the return type:

BUG=596760
==========

to

==========
Remove WTF_ATTRIBUTE_PRINTF.

Use PRINTF_FORMAT defined in base/compiler_specific.h instead.
Also, prepend PRINTF_FORMAT to functions.

https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_D...
> Attributes, and macros that expand to attributes, appear at the very beginning
> of the function declaration or definition, before the return type:

BUG=596760

Committed: https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe
Cr-Commit-Position: refs/heads/master@{#433825}
==========

[commit-bot: I haz the power, 2016-11-22 09:33:54]

Patchset 3 (id:??) landed as
https://crrev.com/ab725021cade9b879960ee8e8e493e33b537cbfe
Cr-Commit-Position: refs/heads/master@{#433825}