Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Issue 2513343005: Apply the font scale factor when generating stroke geometry for <text> (Closed)

Created:
4 years, 1 month ago by fs
Modified:
4 years ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply the font scale factor when generating stroke geometry for <text> Because of the special font scale factor applied to <svg:text> to bring it into a pseudo "host" transform, the stroke geometry would end up being generated in/relative to the wrong coordinate space. Apply the same scale to dash-related properties as was previously applied to stroke-width. BUG=667453 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/faa703d5f2fb405a577ee2debc0c04be68aceb79 Cr-Commit-Position: refs/heads/master@{#434135}

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
fs
4 years, 1 month ago (2016-11-22 14:15:19 UTC) #7
pdr.
LGTM
4 years, 1 month ago (2016-11-22 22:58:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513343005/1
4 years ago (2016-11-23 08:44:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 08:48:59 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-23 08:51:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faa703d5f2fb405a577ee2debc0c04be68aceb79
Cr-Commit-Position: refs/heads/master@{#434135}

Powered by Google App Engine
This is Rietveld 408576698