Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2513343004: [debug-wrapper] Migrate suspended generator scope test (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug-wrapper] Migrate suspended generator scope test Unfortunately, there's currently no satisfying way of accessing scopes of suspended generator objects through inspector. This CL implements access to such scopes through runtime functions instead. BUG=v8:5530 Committed: https://crrev.com/cda1a60ab3ed93b696a812e538e46ff81677a2ba Cr-Commit-Position: refs/heads/master@{#41179}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -568 lines) Patch
A + test/debugger/debug/debug-scopes-suspended-generators.js View 20 chunks +86 lines, -98 lines 0 comments Download
M test/debugger/test-api.js View 1 1 chunk +44 lines, -0 lines 0 comments Download
D test/mjsunit/debug-scopes-suspended-generators.js View 1 chunk +0 lines, -470 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
jgruber
4 years, 1 month ago (2016-11-21 15:41:20 UTC) #6
Yang
On 2016/11/21 15:41:20, jgruber wrote: lgtm.
4 years, 1 month ago (2016-11-22 08:28:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513343004/1
4 years, 1 month ago (2016-11-22 12:45:36 UTC) #9
commit-bot: I haz the power
Failed to apply patch for test/debugger/debug/debug-script.js: While running git apply --index -p1; error: patch failed: ...
4 years, 1 month ago (2016-11-22 12:47:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513343004/20001
4 years, 1 month ago (2016-11-22 13:07:26 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 13:31:57 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 13:32:20 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cda1a60ab3ed93b696a812e538e46ff81677a2ba
Cr-Commit-Position: refs/heads/master@{#41179}

Powered by Google App Engine
This is Rietveld 408576698