Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2513323002: bluetooth: Include connected device in the chooser.

Created:
4 years, 1 month ago by jlebel
Modified:
4 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jracle (use Gerrit), ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Include connected device in the chooser. Devices already connected by other app than chome, are not advertising. The choose adds devices returned by to: BluetoothAdapter::RetrieveGattConnectedDevicesWithDiscoveryFilter() Related to: https://codereview.chromium.org/2339253002 BUG=2339253002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
jlebel
Hello Giovanni, This code patch should be the last part of https://codereview.chromium.org/2339253002 with updating BluetoothDeviceChooserController.
4 years, 1 month ago (2016-11-20 19:14:13 UTC) #3
ortuno
We should hold off until we implement the function on android (http://crrev.com/2499913002). The tests for ...
4 years, 1 month ago (2016-11-21 04:48:02 UTC) #4
François Beaufort
4 years ago (2016-12-13 15:28:54 UTC) #7
On 2016/11/21 04:48:02, ortuno wrote:
> We should hold off until we implement the function on android
> (http://crrev.com/2499913002). The tests for PopulateConnectedDevices are very
> similar to the tests we will need for this. Rather than adding the same tests
> again I would rather we implement the function on android, replace
> PopulateConnectedDevices with it and fix the existing tests.

Please update
http://forum.espruino.com/conversations/296919/?offset=25#comment13367614 when
this patch lands.

Powered by Google App Engine
This is Rietveld 408576698