Description was changed from
==========
Turn on Analytic AA in Chrome (take 4)
Migrated from http://crrev.com/2520553002.
Original author: liyuqian@chromium.org
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
R=fmalita@chromium.org,liyuqian@chromium.org
==========
to
==========
Turn on Analytic AA in Chrome (take 4)
Migrated from http://crrev.com/2520553002.
Original author: liyuqian@chromium.org
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
R=fmalita@chromium.org,liyuqian@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========
f(malita)
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/1823)
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/276991) linux_chromium_chromeos_rel_ng on ...
4 years, 1 month ago
(2016-11-21 20:11:33 UTC)
#15
Dry run: Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/2016)
Description was changed from
==========
Turn on Analytic AA in Chrome (take 4)
Migrated from http://crrev.com/2520553002.
Original author: liyuqian@chromium.org
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
R=fmalita@chromium.org,liyuqian@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========
to
==========
Turn on Analytic AA in Chrome (take 4)
Migrated from http://crrev.com/2520553002.
Original author: liyuqian@chromium.org
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
R=fmalita@chromium.org,liyuqian@chromium.orgTBR=ajuma@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========
commit-bot: I haz the power
Description was changed from ========== Turn on Analytic AA in Chrome (take 4) Migrated from ...
Description was changed from
==========
Turn on Analytic AA in Chrome (take 4)
Migrated from http://crrev.com/2520553002.
Original author: liyuqian@chromium.org
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
R=fmalita@chromium.org,liyuqian@chromium.orgTBR=ajuma@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========
to
==========
Turn on Analytic AA in Chrome (take 4)
Migrated from http://crrev.com/2520553002.
Original author: liyuqian@chromium.org
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
R=fmalita@chromium.org,liyuqian@chromium.orgTBR=ajuma@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Committed: https://crrev.com/1b4f5e9fcab8586ae5c6956bfa2f55efbb909b11
Patch from Yuqian Li <liyuqian@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#434565}
==========
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/1b4f5e9fcab8586ae5c6956bfa2f55efbb909b11 Cr-Commit-Position: refs/heads/master@{#434565}
Description was changed from
==========
Turn on Analytic AA in Chrome (take 4)
Migrated from http://crrev.com/2520553002.
Original author: liyuqian@chromium.org
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
R=fmalita@chromium.org,liyuqian@chromium.orgTBR=ajuma@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Committed: https://crrev.com/1b4f5e9fcab8586ae5c6956bfa2f55efbb909b11
Patch from Yuqian Li <liyuqian@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#434565}
==========
to
==========
Turn on Analytic AA in Chrome (take 4)
Migrated from http://crrev.com/2520553002.
Original author: liyuqian@chromium.org
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
R=fmalita@chromium.org,liyuqian@chromium.orgTBR=ajuma@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Committed:
https://chromium.googlesource.com/chromium/src/+/1b4f5e9fcab8586ae5c6956bfa2f...
==========
f(malita)
Committed patchset #6 (id:100001) manually as 1b4f5e9fcab8586ae5c6956bfa2f55efbb909b11 (presubmit successful).
On 2016/11/26 03:51:49, f(malita) wrote:
> Committed patchset #6 (id:100001) manually as
> 1b4f5e9fcab8586ae5c6956bfa2f55efbb909b11 (presubmit successful).
Landed manually, with a massive rebaseline:
8467 files changed, 374 insertions(+), 247 deletions(-)
Note for sheriffs:
I'll check the bots in the morning and try to clean up any fallout. With so
many update baselines, some stuff is bound to have fallen through the cracks; if
you notice minor anti-aliasing pixel diffs, feel free to rebaseline (or suppress
and assign to myself or Yuqian).
Also, if you must revert, you'll have to revert the actual revision manually
(reverting this uploaded CL won't help).
f(malita)
On 2016/11/26 03:55:16, f(malita) wrote: > On 2016/11/26 03:51:49, f(malita) wrote: > > Committed patchset ...
On 2016/11/26 03:55:16, f(malita) wrote:
> On 2016/11/26 03:51:49, f(malita) wrote:
> > Committed patchset #6 (id:100001) manually as
> > 1b4f5e9fcab8586ae5c6956bfa2f55efbb909b11 (presubmit successful).
>
> Landed manually, with a massive rebaseline:
>
> 8467 files changed, 374 insertions(+), 247 deletions(-)
>
> Note for sheriffs:
>
> I'll check the bots in the morning and try to clean up any fallout. With so
> many update baselines, some stuff is bound to have fallen through the cracks;
if
> you notice minor anti-aliasing pixel diffs, feel free to rebaseline (or
suppress
> and assign to myself or Yuqian).
>
> Also, if you must revert, you'll have to revert the actual revision manually
> (reverting this uploaded CL won't help).
Reverted in
https://chromium.googlesource.com/chromium/src/+/53d5e24291f6750007376ea168a2...,
because the rebaseline too did not pull results for all platforms. E.g.
Mac10_11_retina had 2111 failures:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11_...
The apparent reason for that is some sort of trybot borkage - missing results:
https://storage.googleapis.com/chromium-layout-test-archives/mac10_11_retina_...
Sigh.
liyuqian_chromium.org
Thank you Florin! Is there anything that I can do to help fix the problem? ...
Thank you Florin! Is there anything that I can do to help fix the problem?
On Sat, Nov 26, 2016 at 12:20 AM, <fmalita@chromium.org> wrote:
> On 2016/11/26 03:55:16, f(malita) wrote:
> > On 2016/11/26 03:51:49, f(malita) wrote:
> > > Committed patchset #6 (id:100001) manually as
> > > 1b4f5e9fcab8586ae5c6956bfa2f55efbb909b11 (presubmit successful).
> >
> > Landed manually, with a massive rebaseline:
> >
> > 8467 files changed, 374 insertions(+), 247 deletions(-)
> >
> > Note for sheriffs:
> >
> > I'll check the bots in the morning and try to clean up any fallout. With
> so
> > many update baselines, some stuff is bound to have fallen through the
> cracks;
> if
> > you notice minor anti-aliasing pixel diffs, feel free to rebaseline (or
> suppress
> > and assign to myself or Yuqian).
> >
> > Also, if you must revert, you'll have to revert the actual revision
> manually
> > (reverting this uploaded CL won't help).
>
> Reverted in
> https://chromium.googlesource.com/chromium/src/+/
> 53d5e24291f6750007376ea168a2b18b2fec5aa8,
> because the rebaseline too did not pull results for all platforms. E.g.
> Mac10_11_retina had 2111 failures:
> https://storage.googleapis.com/chromium-layout-test-
> archives/WebKit_Mac10_11__retina_/9302/layout-test-results/results.html
>
> The apparent reason for that is some sort of trybot borkage - missing
> results:
> https://storage.googleapis.com/chromium-layout-test-
> archives/mac10_11_retina_blink_rel/1321/layout-test-results/results.html
>
> Sigh.
>
> https://codereview.chromium.org/2513303002/
>
--
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.
liyuqian_chromium.org
Thank you Florin! Is there anything that I can do to help fix the problem? ...
Thank you Florin! Is there anything that I can do to help fix the problem?
On Sat, Nov 26, 2016 at 12:20 AM, <fmalita@chromium.org> wrote:
> On 2016/11/26 03:55:16, f(malita) wrote:
> > On 2016/11/26 03:51:49, f(malita) wrote:
> > > Committed patchset #6 (id:100001) manually as
> > > 1b4f5e9fcab8586ae5c6956bfa2f55efbb909b11 (presubmit successful).
> >
> > Landed manually, with a massive rebaseline:
> >
> > 8467 files changed, 374 insertions(+), 247 deletions(-)
> >
> > Note for sheriffs:
> >
> > I'll check the bots in the morning and try to clean up any fallout. With
> so
> > many update baselines, some stuff is bound to have fallen through the
> cracks;
> if
> > you notice minor anti-aliasing pixel diffs, feel free to rebaseline (or
> suppress
> > and assign to myself or Yuqian).
> >
> > Also, if you must revert, you'll have to revert the actual revision
> manually
> > (reverting this uploaded CL won't help).
>
> Reverted in
> https://chromium.googlesource.com/chromium/src/+/
> 53d5e24291f6750007376ea168a2b18b2fec5aa8,
> because the rebaseline too did not pull results for all platforms. E.g.
> Mac10_11_retina had 2111 failures:
> https://storage.googleapis.com/chromium-layout-test-
> archives/WebKit_Mac10_11__retina_/9302/layout-test-results/results.html
>
> The apparent reason for that is some sort of trybot borkage - missing
> results:
> https://storage.googleapis.com/chromium-layout-test-
> archives/mac10_11_retina_blink_rel/1321/layout-test-results/results.html
>
> Sigh.
>
> https://codereview.chromium.org/2513303002/
>
--
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.
f(malita)
On 2016/11/26 13:51:08, liyuqian_chromium.org wrote: > Thank you Florin! Is there anything that I can ...
On 2016/11/26 13:51:08, liyuqian_chromium.org wrote:
> Thank you Florin! Is there anything that I can do to help fix the problem?
>
Just retry I guess, hopefully that was a transient problem. I'll re-upload the
patch and give it another shot.
f(malita)
On 2016/11/26 13:55:43, f(malita) wrote: > On 2016/11/26 13:51:08, http://liyuqian_chromium.org wrote: > > Thank you ...
On 2016/11/26 13:55:43, f(malita) wrote:
> On 2016/11/26 13:51:08, http://liyuqian_chromium.org wrote:
> > Thank you Florin! Is there anything that I can do to help fix the problem?
> >
>
> Just retry I guess, hopefully that was a transient problem. I'll re-upload
the
> patch and give it another shot.
Moved to https://codereview.chromium.org/2530263002/.
Issue 2513303002: Turn on Analytic AA in Chrome (take 4)
(Closed)
Created 4 years, 1 month ago by f(malita)
Modified 4 years ago
Reviewers: f(malita), liyuqian_chromium.org
Base URL:
Comments: 0
Chromium Code Reviews
Issue
2513303002:
Turn on Analytic AA in Chrome (take 4) (Closed)
