Revert of Avoid special handling of LayoutSVGForeignObject about its paint offset

Revert of Avoid special handling of LayoutSVGForeignObject about its paint offset (patchset #2 id:20001 of https://codereview.chromium.org/2512493003/ )

Reason for revert:
It is incorrect to treat the HTML viewport defined by a LayoutSVGForeignObject
as the "local SVG coordinate space", because it's not the space that the local svg
transform, clip path and filters apply. This CL is wrong because it treats the wrong LayoutSVGForeignObject::localToParentSVGTransform() as correct and used a wrong way
to remedy that. This CL breaks clip path on foreignObject because the clip path is
applied in wrong space.

Original issue's description:
> Avoid special handling of LayoutSVGForeignObject about its paint offset
>
> Previously we painted a LayoutSVGForeignObject in the following way:
> 1 Issue transform and clip based on localSVGTransform;
> 2 Call BlockFlowPainter::paint with zero LayoutPoint()
> 3 BlockFlowPainter::paint uses the object's location() as the actual
>   paint offset.
>
> The above painting method also required us to generate the same paint
> properties in PaintPropertyTreeBuilder.
>
> This CL change painting of LayoutSVGForiegnObject in a new way:
> 1 Issue transform and clip based on localToSVGParentTransform which
>   includes the viewport offset;
> 2 Call BlockFlowPainter::paint with -location() as the paint offset;
> 3 BlockFlowPainter::paint then add the object's location() to the
>   paint offset which results a zero paint offset.
>
> With the new method, LayoutSVGForeignObject behaves more like a normal
> SVG object so we can remove some special handling of it.
>
> BUG=666416
>
> x
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab
> Cr-Commit-Position: refs/heads/master@{#433080}

TBR=pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/a85757755e1db65b954b4a40283ad5660ae84630
Cr-Commit-Position: refs/heads/master@{#433456}

[Xianzhu, 2016-11-20 02:13:23]

Created Revert of Avoid special handling of LayoutSVGForeignObject about its
paint offset

[Xianzhu, 2016-11-20 05:16:34]

Description was changed from

==========
Revert of Avoid special handling of LayoutSVGForeignObject about its paint
offset (patchset #2 id:20001 of https://codereview.chromium.org/2512493003/ )

Reason for revert:
It is incorrect to treat the HTML viewport defined by a LayoutSVGForeignObject
as the "local SVG coordinate space", because it's not the space that the local
svg
transform, clip path and filters apply. This CL is wrong because it treats the
wrong LayoutSVGForeignObject::localToParentSVGTransform() as correct and used a
wrong way
to remedy that. This CL breaks clip path on foreignObject because the clip path
is
applied in wrong space.


Original issue's description:
> Avoid special handling of LayoutSVGForeignObject about its paint offset
> 
> Previously we painted a LayoutSVGForeignObject in the following way:
> 1 Issue transform and clip based on localSVGTransform;
> 2 Call BlockFlowPainter::paint with zero LayoutPoint()
> 3 BlockFlowPainter::paint uses the object's location() as the actual
>   paint offset.
> 
> The above painting method also required us to generate the same paint
> properties in PaintPropertyTreeBuilder.
> 
> This CL change painting of LayoutSVGForiegnObject in a new way:
> 1 Issue transform and clip based on localToSVGParentTransform which
>   includes the viewport offset;
> 2 Call BlockFlowPainter::paint with -location() as the paint offset;
> 3 BlockFlowPainter::paint then add the object's location() to the
>   paint offset which results a zero paint offset.
> 
> With the new method, LayoutSVGForeignObject behaves more like a normal
> SVG object so we can remove some special handling of it.
> 
> BUG=666416
> 
> x
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab
> Cr-Commit-Position: refs/heads/master@{#433080}

TBR=pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=666416
==========

to

==========
Revert of Avoid special handling of LayoutSVGForeignObject about its paint
offset (patchset #2 id:20001 of https://codereview.chromium.org/2512493003/ )

Reason for revert:
It is incorrect to treat the HTML viewport defined by a LayoutSVGForeignObject
as the "local SVG coordinate space", because it's not the space that the local
svg
transform, clip path and filters apply. This CL is wrong because it treats the
wrong LayoutSVGForeignObject::localToParentSVGTransform() as correct and used a
wrong way
to remedy that. This CL breaks clip path on foreignObject because the clip path
is
applied in wrong space.


Original issue's description:
> Avoid special handling of LayoutSVGForeignObject about its paint offset
> 
> Previously we painted a LayoutSVGForeignObject in the following way:
> 1 Issue transform and clip based on localSVGTransform;
> 2 Call BlockFlowPainter::paint with zero LayoutPoint()
> 3 BlockFlowPainter::paint uses the object's location() as the actual
>   paint offset.
> 
> The above painting method also required us to generate the same paint
> properties in PaintPropertyTreeBuilder.
> 
> This CL change painting of LayoutSVGForiegnObject in a new way:
> 1 Issue transform and clip based on localToSVGParentTransform which
>   includes the viewport offset;
> 2 Call BlockFlowPainter::paint with -location() as the paint offset;
> 3 BlockFlowPainter::paint then add the object's location() to the
>   paint offset which results a zero paint offset.
> 
> With the new method, LayoutSVGForeignObject behaves more like a normal
> SVG object so we can remove some special handling of it.
> 
> BUG=666416
> 
> x
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab
> Cr-Commit-Position: refs/heads/master@{#433080}

TBR=pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-11-20 05:18:15]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-20 05:18:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-20 08:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-20 08:57:45]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-11-20 18:10:05]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-11-20 18:10:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-20 18:13:22]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1479665405242970,
"parent_rev": ["7d0cbf3cb8c422c2972a56a6f515f5fbb20e263e", null], "commit_rev":
["6113299a6a090b976eeca6f36b9683bf21046da7", null]}

[commit-bot: I haz the power, 2016-11-20 18:13:46]

Committed patchset #2 (id:170001)

[commit-bot: I haz the power, 2016-11-20 18:16:09]

Description was changed from

==========
Revert of Avoid special handling of LayoutSVGForeignObject about its paint
offset (patchset #2 id:20001 of https://codereview.chromium.org/2512493003/ )

Reason for revert:
It is incorrect to treat the HTML viewport defined by a LayoutSVGForeignObject
as the "local SVG coordinate space", because it's not the space that the local
svg
transform, clip path and filters apply. This CL is wrong because it treats the
wrong LayoutSVGForeignObject::localToParentSVGTransform() as correct and used a
wrong way
to remedy that. This CL breaks clip path on foreignObject because the clip path
is
applied in wrong space.


Original issue's description:
> Avoid special handling of LayoutSVGForeignObject about its paint offset
> 
> Previously we painted a LayoutSVGForeignObject in the following way:
> 1 Issue transform and clip based on localSVGTransform;
> 2 Call BlockFlowPainter::paint with zero LayoutPoint()
> 3 BlockFlowPainter::paint uses the object's location() as the actual
>   paint offset.
> 
> The above painting method also required us to generate the same paint
> properties in PaintPropertyTreeBuilder.
> 
> This CL change painting of LayoutSVGForiegnObject in a new way:
> 1 Issue transform and clip based on localToSVGParentTransform which
>   includes the viewport offset;
> 2 Call BlockFlowPainter::paint with -location() as the paint offset;
> 3 BlockFlowPainter::paint then add the object's location() to the
>   paint offset which results a zero paint offset.
> 
> With the new method, LayoutSVGForeignObject behaves more like a normal
> SVG object so we can remove some special handling of it.
> 
> BUG=666416
> 
> x
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab
> Cr-Commit-Position: refs/heads/master@{#433080}

TBR=pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Revert of Avoid special handling of LayoutSVGForeignObject about its paint
offset (patchset #2 id:20001 of https://codereview.chromium.org/2512493003/ )

Reason for revert:
It is incorrect to treat the HTML viewport defined by a LayoutSVGForeignObject
as the "local SVG coordinate space", because it's not the space that the local
svg
transform, clip path and filters apply. This CL is wrong because it treats the
wrong LayoutSVGForeignObject::localToParentSVGTransform() as correct and used a
wrong way
to remedy that. This CL breaks clip path on foreignObject because the clip path
is
applied in wrong space.

Original issue's description:
> Avoid special handling of LayoutSVGForeignObject about its paint offset
>
> Previously we painted a LayoutSVGForeignObject in the following way:
> 1 Issue transform and clip based on localSVGTransform;
> 2 Call BlockFlowPainter::paint with zero LayoutPoint()
> 3 BlockFlowPainter::paint uses the object's location() as the actual
>   paint offset.
>
> The above painting method also required us to generate the same paint
> properties in PaintPropertyTreeBuilder.
>
> This CL change painting of LayoutSVGForiegnObject in a new way:
> 1 Issue transform and clip based on localToSVGParentTransform which
>   includes the viewport offset;
> 2 Call BlockFlowPainter::paint with -location() as the paint offset;
> 3 BlockFlowPainter::paint then add the object's location() to the
>   paint offset which results a zero paint offset.
>
> With the new method, LayoutSVGForeignObject behaves more like a normal
> SVG object so we can remove some special handling of it.
>
> BUG=666416
>
> x
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/74454dfeaa27a9f696824e0a2a1548175d2e26ab
> Cr-Commit-Position: refs/heads/master@{#433080}

TBR=pdr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=666416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/a85757755e1db65b954b4a40283ad5660ae84630
Cr-Commit-Position: refs/heads/master@{#433456}
==========

[commit-bot: I haz the power, 2016-11-20 18:16:10]

Patchset 2 (id:??) landed as
https://crrev.com/a85757755e1db65b954b4a40283ad5660ae84630
Cr-Commit-Position: refs/heads/master@{#433456}