Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2513273003: Fix CPDFImage::IsInline(). (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix CPDFImage::IsInline(). Commit 137a344a changed its behavior. BUG=chromium:667012 Committed: https://pdfium.googlesource.com/pdfium/+/7daa6fb286d1b5d65f99521f3314083e86d93e3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M core/fpdfapi/page/cpdf_image.h View 4 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/page/cpdf_image.cpp View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Lei Zhang
4 years, 1 month ago (2016-11-20 22:57:00 UTC) #6
dsinclair
Looks good, although Tom should take a look. Can you update the description with what ...
4 years, 1 month ago (2016-11-21 13:55:56 UTC) #7
Tom Sepez
On 2016/11/21 13:55:56, dsinclair wrote: > Looks good, although Tom should take a look. Can ...
4 years, 1 month ago (2016-11-21 18:01:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513273003/1
4 years, 1 month ago (2016-11-21 18:01:15 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 18:12:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7daa6fb286d1b5d65f99521f3314083e86d9...

Powered by Google App Engine
This is Rietveld 408576698