Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2513183002: Add a use counter for Link rel=serviceworker headers. (Closed)

Created:
4 years, 1 month ago by Marijn Kruisselbrink
Modified:
4 years, 1 month ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, gavinp+prerender_chromium.org, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a use counter for Link rel=serviceworker headers. Even though these link headers aren't processed in blink, this is still the most sensible place for a use counter for these. BUG=582310, 667086 Committed: https://crrev.com/9c76cfaf64b27534abe2663b2a1768737d64d4f9 Cr-Commit-Position: refs/heads/master@{#433444}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Marijn Kruisselbrink
4 years, 1 month ago (2016-11-19 00:53:41 UTC) #4
Ilya Sherman
histograms.xml lgtm
4 years, 1 month ago (2016-11-19 00:55:45 UTC) #5
Yoav Weiss
On 2016/11/19 00:55:45, Ilya Sherman wrote: > histograms.xml lgtm core/ LGTM
4 years, 1 month ago (2016-11-19 20:42:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513183002/1
4 years, 1 month ago (2016-11-19 22:10:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513183002/1
4 years, 1 month ago (2016-11-20 01:24:49 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-20 03:59:36 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-20 04:02:13 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c76cfaf64b27534abe2663b2a1768737d64d4f9
Cr-Commit-Position: refs/heads/master@{#433444}

Powered by Google App Engine
This is Rietveld 408576698