Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2513153002: Don't create boxes for the contents of display: none iframes. (Closed)

Created:
4 years, 1 month ago by esprehn
Modified:
3 years, 7 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't create boxes for the contents of display: none iframes. BUG=650433

Patch Set 1 #

Patch Set 2 : Handle dynamic changes properly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/StyleChangeReason.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleChangeReason.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp View 1 2 chunks +18 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
esprehn
Description was changed from ========== Don't create boxes for the contents of display: none iframes. ...
4 years, 1 month ago (2016-11-18 23:02:51 UTC) #1
esprehn
The CQ bit was checked by esprehn@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-19 00:35:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513153002/20001
4 years, 1 month ago (2016-11-19 00:36:45 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-19 01:53:54 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 01:53:55 UTC) #5 
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698