Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2513143002: Fixed crash when exiting page using GVR controller w/ the gamepad API (Closed)

Created:
4 years, 1 month ago by bajones
Modified:
4 years, 1 month ago
Reviewers:
mthiesse, asimjour1, billorr
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed crash when exiting page using GVR controller w/ the gamepad API BUG=666911 Committed: https://crrev.com/8037248c76fe651086adce2706c50a3cf693ff5b Cr-Commit-Position: refs/heads/master@{#433358}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M device/vr/android/gvr/gvr_gamepad_data_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/android/gvr/gvr_gamepad_data_fetcher.cc View 2 chunks +5 lines, -6 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
billorr
https://codereview.chromium.org/2513143002/diff/1/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc File device/vr/android/gvr/gvr_gamepad_data_fetcher.cc (left): https://codereview.chromium.org/2513143002/diff/1/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc#oldcode60 device/vr/android/gvr/gvr_gamepad_data_fetcher.cc:60: user_prefs_.reset(new gvr::UserPrefs(gvr_api->GetUserPrefs().cobj())); I assume the bug is that the ...
4 years, 1 month ago (2016-11-18 22:27:52 UTC) #2
bajones
On 2016/11/18 22:27:52, billorr wrote: > https://codereview.chromium.org/2513143002/diff/1/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc > File device/vr/android/gvr/gvr_gamepad_data_fetcher.cc (left): > > https://codereview.chromium.org/2513143002/diff/1/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc#oldcode60 > ...
4 years, 1 month ago (2016-11-18 22:37:46 UTC) #3
bajones
4 years, 1 month ago (2016-11-18 22:52:33 UTC) #5
asimjour1
On 2016/11/18 22:52:33, bajones wrote: lgtm
4 years, 1 month ago (2016-11-18 23:13:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513143002/1
4 years, 1 month ago (2016-11-18 23:41:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 00:53:31 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 00:56:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8037248c76fe651086adce2706c50a3cf693ff5b
Cr-Commit-Position: refs/heads/master@{#433358}

Powered by Google App Engine
This is Rietveld 408576698