Fixed crash when exiting page using GVR controller w/ the gamepad API

Fixed crash when exiting page using GVR controller w/ the gamepad API

BUG=666911
Committed: https://crrev.com/8037248c76fe651086adce2706c50a3cf693ff5b
Cr-Commit-Position: refs/heads/master@{#433358}

[billorr, 2016-11-18 22:27:51]

billorr@chromium.org changed reviewers:
+ billorr@chromium.org

[billorr, 2016-11-18 22:27:52]

https://codereview.chromium.org/2513143002/diff/1/device/vr/android/gvr/gvr_g...
File device/vr/android/gvr/gvr_gamepad_data_fetcher.cc (left):

https://codereview.chromium.org/2513143002/diff/1/device/vr/android/gvr/gvr_g...
device/vr/android/gvr/gvr_gamepad_data_fetcher.cc:60: user_prefs_.reset(new
gvr::UserPrefs(gvr_api->GetUserPrefs().cobj()));
I assume the bug is that the user_prefs_ object goes away at the wrong time.  So
the fix is just extracting data while we know the user_prefs is good?

Is controller_api_ still valid?

[bajones, 2016-11-18 22:37:46]

On 2016/11/18 22:27:52, billorr wrote:
>
https://codereview.chromium.org/2513143002/diff/1/device/vr/android/gvr/gvr_g...
> File device/vr/android/gvr/gvr_gamepad_data_fetcher.cc (left):
> 
>
https://codereview.chromium.org/2513143002/diff/1/device/vr/android/gvr/gvr_g...
> device/vr/android/gvr/gvr_gamepad_data_fetcher.cc:60: user_prefs_.reset(new
> gvr::UserPrefs(gvr_api->GetUserPrefs().cobj()));
> I assume the bug is that the user_prefs_ object goes away at the wrong time. 
So
> the fix is just extracting data while we know the user_prefs is good?

Precisely.
 
> Is controller_api_ still valid?

Yes, it seems the controller_api_ doesn't have any issues outliving the
gvr_context that it was created with, but the UserPrefs object lifetime is more
closely tied with the gvr_context object.

[bajones, 2016-11-18 22:52:32]

bajones@chromium.org changed reviewers:
+ mthiesse@chromium.org

[asimjour1, 2016-11-18 23:13:54]

On 2016/11/18 22:52:33, bajones wrote:

lgtm

[bajones, 2016-11-18 23:40:36]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2016-11-18 23:41:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 00:53:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-19 00:56:27]

Description was changed from

==========
Fixed crash when exiting page using GVR controller w/ the gamepad API

BUG=666911
==========

to

==========
Fixed crash when exiting page using GVR controller w/ the gamepad API

BUG=666911

Committed: https://crrev.com/8037248c76fe651086adce2706c50a3cf693ff5b
Cr-Commit-Position: refs/heads/master@{#433358}
==========

[commit-bot: I haz the power, 2016-11-19 00:56:28]

Patchset 1 (id:??) landed as
https://crrev.com/8037248c76fe651086adce2706c50a3cf693ff5b
Cr-Commit-Position: refs/heads/master@{#433358}