Chromium Code Reviews Chromium Code Reviews
Issue
2513133002:
Revert of Disable CTPolicyEnforcerTest.ConformsToCTEVPolicyIfSCTBeforeEnforcementDate (Closed)
DescriptionRevert of Disable CTPolicyEnforcerTest.ConformsToCTEVPolicyIfSCTBeforeEnforcementDate (patchset #1 id:1 of https://codereview.chromium.org/2517673003/ )
Reason for revert:
Causes compile failure:
FAILED: obj/net/_net_unittests__library/ct_policy_enforcer_unittest.o
/mnt/data/b/build/slave/cache/cipd/goma/gomacc ../../third_party/android_tools/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-g++ -MMD -MF obj/net/_net_unittests__library/ct_policy_enforcer_unittest.o.d -DUSE_KERBEROS -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DUSE_PROPRIETARY_CODECS -DSAFE_BROWSING_DB_REMOTE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DENABLE_WEBVR -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -DANDROID_NDK_VERSION=r12b -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__GNU_SOURCE=1 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUNIT_TEST -I../.. -Igen -I../../testing/gtest/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../testing/gmock_custom -I../../testing/gmock/include -I../../third_party/zlib -I../../v8/include -Igen/v8/include -Igen/net/net_test_jni_headers -Igen/net/net_test_jni_headers/net/test -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -ffunction-sections -fno-short-enums -finline-limit=64 -Wall -Werror -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Os -fno-omit-frame-pointer -gdwarf-3 -g1 --sysroot=../../third_party/android_tools/ndk/platforms/android-21/arch-arm64 -fvisibility=hidden -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -fno-rtti -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fno-exceptions -c ../../net/cert/ct_policy_enforcer_unittest.cc -o obj/net/_net_unittests__library/ct_policy_enforcer_unittest.o
../../net/cert/ct_policy_enforcer_unittest.cc:183:1: error: 'DISABLED_ConformsToCTEVPolicyIfSCTBeforeEnforcementDate' does not name a type
DISABLED_ConformsToCTEVPolicyIfSCTBeforeEnforcementDate
Original issue's description:
> Disable CTPolicyEnforcerTest.ConformsToCTEVPolicyIfSCTBeforeEnforcementDate
>
> It's flaky on Android
>
> BUG=666820
> TBR=estade@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/afb4d4b1e2792de2632e16d44616a8bcfe0f5a86
> Cr-Commit-Position: refs/heads/master@{#433307}
TBR=fsamuel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=666820
Committed: https://crrev.com/cefd44b8edf187c655024c9b5eabb166422bcd2c
Cr-Commit-Position: refs/heads/master@{#433309}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||
