Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2513123002: Remove IndexedDBDispatcher::init_params() (Closed)

Created:
4 years, 1 month ago by rlanday
Modified:
4 years, 1 month ago
Reviewers:
danakj, *cmumford
CC:
chromium-reviews, cmumford, danakj, darin-cc_chromium.org, jam, jsbell+idb_chromium.orgk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IndexedDBDispatcher::init_params() It came up during a code review (involving refactoring IDMap, which this function uses) that this function appears to be unused: https://codereview.chromium.org/2480293004/diff/120001/content/child/indexed_db/indexed_db_dispatcher.h#newcode133 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/child/indexed_db/indexed_db_dispatcher.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
rlanday
4 years, 1 month ago (2016-11-18 22:24:03 UTC) #4
danakj
LGTM
4 years, 1 month ago (2016-11-18 22:25:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513123002/1
4 years, 1 month ago (2016-11-18 23:21:10 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/308709)
4 years, 1 month ago (2016-11-18 23:55:08 UTC) #12
rlanday
4 years, 1 month ago (2016-11-21 17:39:48 UTC) #14
rlanday
Looks like I need cmumford's review before it will let me land this
4 years, 1 month ago (2016-11-21 17:41:01 UTC) #15
cmumford
lgtm
4 years, 1 month ago (2016-11-22 17:39:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513123002/1
4 years, 1 month ago (2016-11-22 18:28:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/169092)
4 years, 1 month ago (2016-11-22 19:00:22 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513123002/1
4 years, 1 month ago (2016-11-22 20:49:41 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/310820)
4 years, 1 month ago (2016-11-22 20:56:03 UTC) #24
rlanday
4 years, 1 month ago (2016-11-22 22:52:32 UTC) #25
On 2016/11/22 at 20:56:03, commit-bot wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Looks like this change was already made in
https://codereview.chromium.org/2500263003 before I could land this :)

Powered by Google App Engine
This is Rietveld 408576698