Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1872)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 2513113002: Remove strike-register code from QuicCryptoServerConfig (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_crypto_server_config_peer.cc ('k') | net/tools/quic/quic_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 21e20d6249689f0e57ea18f565f09286a7f3ee9f..a02d12badc5f0f58f2d6d0df4bedc7f8f068db96 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -277,7 +277,6 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
client_writer_(nullptr),
server_writer_(nullptr),
server_started_(false),
- strike_register_no_startup_period_(false),
chlo_multiplier_(0),
stream_factory_(nullptr),
support_server_push_(false) {
@@ -433,8 +432,7 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
auto test_server =
new QuicTestServer(CryptoTestUtils::ProofSourceForTesting(),
server_config_, server_supported_versions_);
- server_thread_.reset(new ServerThread(test_server, server_address_,
- strike_register_no_startup_period_));
+ server_thread_.reset(new ServerThread(test_server, server_address_));
if (chlo_multiplier_ != 0) {
server_thread_->server()->SetChloMultiplier(chlo_multiplier_);
}
@@ -571,7 +569,6 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
QuicVersionVector client_supported_versions_;
QuicVersionVector server_supported_versions_;
QuicVersion negotiated_version_;
- bool strike_register_no_startup_period_;
size_t chlo_multiplier_;
QuicTestServer::StreamFactory* stream_factory_;
bool support_server_push_;
@@ -850,9 +847,6 @@ TEST_P(EndToEndTest, LargePostNoPacketLossWithDelayAndReordering) {
}
TEST_P(EndToEndTest, LargePostZeroRTTFailure) {
- // Have the server accept 0-RTT without waiting a startup period.
- strike_register_no_startup_period_ = true;
-
// Send a request and then disconnect. This prepares the client to attempt
// a 0-RTT handshake for the next request.
ASSERT_TRUE(Initialize());
@@ -914,9 +908,6 @@ TEST_P(EndToEndTest, LargePostZeroRTTFailure) {
}
TEST_P(EndToEndTest, SynchronousRequestZeroRTTFailure) {
- // Have the server accept 0-RTT without waiting a startup period.
- strike_register_no_startup_period_ = true;
-
// Send a request and then disconnect. This prepares the client to attempt
// a 0-RTT handshake for the next request.
ASSERT_TRUE(Initialize());
@@ -967,9 +958,6 @@ TEST_P(EndToEndTest, SynchronousRequestZeroRTTFailure) {
}
TEST_P(EndToEndTest, LargePostSynchronousRequest) {
- // Have the server accept 0-RTT without waiting a startup period.
- strike_register_no_startup_period_ = true;
-
// Send a request and then disconnect. This prepares the client to attempt
// a 0-RTT handshake for the next request.
ASSERT_TRUE(Initialize());
« no previous file with comments | « net/quic/test_tools/quic_crypto_server_config_peer.cc ('k') | net/tools/quic/quic_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698