[Mac] Fixed the incognito omnibox icon background color

chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm

Index: chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
index d8556da01e7abdf7f0183780c742dd5d30037f6b..829c097dbfb91a405c78300c1828292d21d952f3 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
@@ -23,9 +23,9 @@ const CGFloat kDividerIncognitoGrayScale = 1.0;
 
 // Color values for the hover and pressed background.
 const SkColor kHoverBackgroundColor = 0x14000000;
-const SkColor kHoverDarkBackgroundColor = 0x1E000000;
+const SkColor kHoverDarkBackgroundColor = 0x1EFFFFFF;
 const SkColor kPressedBackgroundColor = 0x1E000000;
-const SkColor kPressedDarkBackgroundColor = 0x3D000000;
+const SkColor kPressedDarkBackgroundColor = 0x3DFFFFFF;
 
 // Amount of inset for the background frame.
 const CGFloat kBackgroundFrameYInset = 2.0;
@@ -180,7 +180,7 @@ void LocationBarDecoration::DrawWithBackgroundInFrame(NSRect frame,
           in_dark_mode ? kHoverDarkBackgroundColor : kHoverBackgroundColor;

[shrike, 2016/11/19 00:01:23]

This line computes the Pressed state color (based on the if statement) but here
you are returning the hover color. As a result, when I run it the hover state is
lighter than the pressed state.

[Robert Sesek, 2016/11/19 00:02:42]

I'd expect hover to be lighter than pressed?

[spqchan, 2016/11/19 00:09:05]

I can't reproduce that. It's matching the specs for me

     } else {
       background_color =
-          in_dark_mode ? kPressedBackgroundColor : kPressedDarkBackgroundColor;
+          in_dark_mode ? kPressedDarkBackgroundColor : kPressedBackgroundColor;
     }
 
     [skia::SkColorToSRGBNSColor(background_color) setFill];