Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: components/password_manager/content/browser/credential_manager_impl.h

Issue 2513033002: Refactor CredentialManagerImpl::RequireUserMediation method. (Closed)
Patch Set: ios Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_I MPL_H_ 5 #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_I MPL_H_
6 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_I MPL_H_ 6 #define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGER_I MPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 83
84 // Schedules a CredentiaManagerPendingRequestTask (during 84 // Schedules a CredentiaManagerPendingRequestTask (during
85 // |OnRequestCredential()|) after the PasswordStore's AffiliationMatchHelper 85 // |OnRequestCredential()|) after the PasswordStore's AffiliationMatchHelper
86 // grabs a list of realms related to the current web origin. 86 // grabs a list of realms related to the current web origin.
87 void ScheduleRequestTask(const GetCallback& callback, 87 void ScheduleRequestTask(const GetCallback& callback,
88 bool zero_click_only, 88 bool zero_click_only,
89 bool include_passwords, 89 bool include_passwords,
90 const std::vector<GURL>& federations, 90 const std::vector<GURL>& federations,
91 const std::vector<std::string>& android_realms); 91 const std::vector<std::string>& android_realms);
92 92
93 // Schedules a CredentialManagerPendingRequireUserMediationTask after the
94 // AffiliationMatchHelper grabs a list of realms related to the current
95 // web origin.
96 void ScheduleRequireMediationTask(
97 const RequireUserMediationCallback& callback,
98 const std::vector<std::string>& android_realms);
99
100 PasswordManagerClient* client_; 93 PasswordManagerClient* client_;
101 std::unique_ptr<CredentialManagerPasswordFormManager> form_manager_; 94 std::unique_ptr<CredentialManagerPasswordFormManager> form_manager_;
102 95
103 // Set to false to disable automatic signing in. 96 // Set to false to disable automatic signing in.
104 BooleanPrefMember auto_signin_enabled_; 97 BooleanPrefMember auto_signin_enabled_;
105 98
106 // When 'OnRequestCredential' is called, it in turn calls out to the 99 // When 'OnRequestCredential' is called, it in turn calls out to the
107 // PasswordStore; we push enough data into Pending*Task objects so that 100 // PasswordStore; we push enough data into Pending*Task objects so that
108 // they can properly respond to the request once the PasswordStore gives 101 // they can properly respond to the request once the PasswordStore gives
109 // us data. 102 // us data.
110 std::unique_ptr<CredentialManagerPendingRequestTask> pending_request_; 103 std::unique_ptr<CredentialManagerPendingRequestTask> pending_request_;
111 std::unique_ptr<CredentialManagerPendingRequireUserMediationTask> 104 std::unique_ptr<CredentialManagerPendingRequireUserMediationTask>
112 pending_require_user_mediation_; 105 pending_require_user_mediation_;
113 106
114 mojo::BindingSet<mojom::CredentialManager> bindings_; 107 mojo::BindingSet<mojom::CredentialManager> bindings_;
115 108
116 base::WeakPtrFactory<CredentialManagerImpl> weak_factory_; 109 base::WeakPtrFactory<CredentialManagerImpl> weak_factory_;
117 110
118 DISALLOW_COPY_AND_ASSIGN(CredentialManagerImpl); 111 DISALLOW_COPY_AND_ASSIGN(CredentialManagerImpl);
119 }; 112 };
120 113
121 } // namespace password_manager 114 } // namespace password_manager
122 115
123 #endif // COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGE R_IMPL_H_ 116 #endif // COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_CONTENT_CREDENTIAL_MANAGE R_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698