[Cronet] Add CookieStoreIOS.

[Cronet] Add CookieStoreIOS.

BUG=666792
Committed: https://crrev.com/3c84be9a60d0576e2006b34badb370a26caef5cf
Cr-Commit-Position: refs/heads/master@{#433343}

[mef, 2016-11-18 17:01:11]

mef@chromium.org changed reviewers:
+ kapishnikov@chromium.org, lilyhoughton@chromium.org

[mef, 2016-11-18 17:58:24]

Description was changed from

==========
[Cronet] Add CookieStoreIOS.

BUG=
==========

to

==========
[Cronet] Add CookieStoreIOS.

BUG=666792
==========

[kapishnikov, 2016-11-18 20:58:03]

https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/crone...
File components/cronet/ios/cronet_environment.mm (right):

https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/crone...
components/cronet/ios/cronet_environment.mm:268: //
net::HTTPProtocolHandlerDelegate::SetInstance(nullptr);
Why do we need it here?

https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/crone...
components/cronet/ios/cronet_environment.mm:348: net::AlternativeService
alternative_service(net::kProtoQUIC, "",
Why are we changing net::AlternateProtocol::QUIC to net::kProtoQUIC?

https://codereview.chromium.org/2513023002/diff/20001/components/cronet/ios/t...
File components/cronet/ios/test/test_server.cc (right):

https://codereview.chromium.org/2513023002/diff/20001/components/cronet/ios/t...
components/cronet/ios/test/test_server.cc:39:
std::unique_ptr<net::test_server::HttpResponse> SetCookieInResponse(
Since we echoing the cookie line in response, should we change the name of the
method to SetAndEchoCookieInResponse? Alternatively, we can document the
behavior in the header.

[mef, 2016-11-18 22:29:36]

Thanks, PTAL.

https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/crone...
File components/cronet/ios/cronet_environment.mm (right):

https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/crone...
components/cronet/ios/cronet_environment.mm:268: //
net::HTTPProtocolHandlerDelegate::SetInstance(nullptr);
On 2016/11/18 20:58:03, kapishnikov wrote:
> Why do we need it here?

git cl format is different for .mm and .cc.

https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/crone...
components/cronet/ios/cronet_environment.mm:348: net::AlternativeService
alternative_service(net::kProtoQUIC, "",
On 2016/11/18 20:58:03, kapishnikov wrote:
> Why are we changing net::AlternateProtocol::QUIC to net::kProtoQUIC?

Synced to head.

https://codereview.chromium.org/2513023002/diff/20001/components/cronet/ios/t...
File components/cronet/ios/test/test_server.cc (right):

https://codereview.chromium.org/2513023002/diff/20001/components/cronet/ios/t...
components/cronet/ios/test/test_server.cc:39:
std::unique_ptr<net::test_server::HttpResponse> SetCookieInResponse(
On 2016/11/18 20:58:03, kapishnikov wrote:
> Since we echoing the cookie line in response, should we change the name of the
> method to SetAndEchoCookieInResponse? Alternatively, we can document the
> behavior in the header.

Done.

[kapishnikov, 2016-11-18 22:32:13]

lgtm

[mef, 2016-11-18 22:35:31]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2016-11-18 22:36:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 00:07:36]

Description was changed from

==========
[Cronet] Add CookieStoreIOS.

BUG=666792
==========

to

==========
[Cronet] Add CookieStoreIOS.

BUG=666792
==========

[commit-bot: I haz the power, 2016-11-19 00:07:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-19 00:11:12]

Description was changed from

==========
[Cronet] Add CookieStoreIOS.

BUG=666792
==========

to

==========
[Cronet] Add CookieStoreIOS.

BUG=666792

Committed: https://crrev.com/3c84be9a60d0576e2006b34badb370a26caef5cf
Cr-Commit-Position: refs/heads/master@{#433343}
==========

[commit-bot: I haz the power, 2016-11-19 00:11:13]

Patchset 3 (id:??) landed as
https://crrev.com/3c84be9a60d0576e2006b34badb370a26caef5cf
Cr-Commit-Position: refs/heads/master@{#433343}