Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2513023002: [Cronet] Add CookieStoreIOS. (Closed)

Created:
4 years, 1 month ago by mef
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Add CookieStoreIOS. BUG=666792 Committed: https://crrev.com/3c84be9a60d0576e2006b34badb370a26caef5cf Cr-Commit-Position: refs/heads/master@{#433343}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Sync #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -425 lines) Patch
M components/cronet/ios/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/ios/cronet_environment.h View 2 chunks +2 lines, -0 lines 0 comments Download
D components/cronet/ios/cronet_environment.cc View 1 1 chunk +0 lines, -416 lines 0 comments Download
A + components/cronet/ios/cronet_environment.mm View 1 4 chunks +7 lines, -1 line 0 comments Download
M components/cronet/ios/test/cronet_http_test.mm View 3 chunks +28 lines, -0 lines 0 comments Download
M components/cronet/ios/test/test_server.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M components/cronet/ios/test/test_server.cc View 1 2 4 chunks +37 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mef
4 years, 1 month ago (2016-11-18 17:01:12 UTC) #2
kapishnikov
https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/cronet_environment.mm File components/cronet/ios/cronet_environment.mm (right): https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/cronet_environment.mm#newcode268 components/cronet/ios/cronet_environment.mm:268: // net::HTTPProtocolHandlerDelegate::SetInstance(nullptr); Why do we need it here? https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/cronet_environment.mm#newcode348 ...
4 years, 1 month ago (2016-11-18 20:58:03 UTC) #4
mef
Thanks, PTAL. https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/cronet_environment.mm File components/cronet/ios/cronet_environment.mm (right): https://codereview.chromium.org/2513023002/diff/1/components/cronet/ios/cronet_environment.mm#newcode268 components/cronet/ios/cronet_environment.mm:268: // net::HTTPProtocolHandlerDelegate::SetInstance(nullptr); On 2016/11/18 20:58:03, kapishnikov wrote: ...
4 years, 1 month ago (2016-11-18 22:29:36 UTC) #5
kapishnikov
lgtm
4 years, 1 month ago (2016-11-18 22:32:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513023002/40001
4 years, 1 month ago (2016-11-18 22:36:31 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-19 00:07:37 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 00:11:13 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3c84be9a60d0576e2006b34badb370a26caef5cf
Cr-Commit-Position: refs/heads/master@{#433343}

Powered by Google App Engine
This is Rietveld 408576698