Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2512983002: [ObjC ARC] Converts ios/chrome/browser/passwords:passwords_generation_utils to ARC.Automatically … (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, pkl (ping after 24h if needed), vabr+watchlistpasswordmanager_chromium.org, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/passwords:passwords_generation_utils to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/a2dd94492b98952e219b65246958e87c15c5304b Cr-Commit-Position: refs/heads/master@{#433557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/passwords/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/passwords/password_generation_utils.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
stkhapugin
PTAL. Passes downstream bots.
4 years, 1 month ago (2016-11-18 17:02:35 UTC) #4
noyau (Ping after 24h)
lgtm
4 years, 1 month ago (2016-11-18 17:19:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512983002/1
4 years, 1 month ago (2016-11-21 12:22:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/71898)
4 years, 1 month ago (2016-11-21 13:35:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512983002/1
4 years, 1 month ago (2016-11-21 15:43:01 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 16:22:01 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 16:25:16 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2dd94492b98952e219b65246958e87c15c5304b
Cr-Commit-Position: refs/heads/master@{#433557}

Powered by Google App Engine
This is Rietveld 408576698