Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: test/debugger/debug/debug-conditional-breakpoints.js

Issue 2512963002: [debug-wrapper] Migrate more tests (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug-scopes.cc ('k') | test/debugger/debug/debug-evaluate-shadowed-context.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/debugger/debug/debug-conditional-breakpoints.js
diff --git a/test/mjsunit/debug-conditional-breakpoints.js b/test/debugger/debug/debug-conditional-breakpoints.js
similarity index 86%
rename from test/mjsunit/debug-conditional-breakpoints.js
rename to test/debugger/debug/debug-conditional-breakpoints.js
index 44148970994426c0a1e3728993936bc20299f8fe..b4b73140ba12688d3e346c23450e319ba36c9e27 100644
--- a/test/mjsunit/debug-conditional-breakpoints.js
+++ b/test/debugger/debug/debug-conditional-breakpoints.js
@@ -25,8 +25,6 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --expose-debug-as debug
-// Get the Debug object exposed from the debug context global object.
Debug = debug.Debug
// Simple debug event handler which just counts the number of break points hit.
@@ -81,19 +79,6 @@ f();
assertEquals(1, break_point_hit_count);
Debug.clearBreakPoint(bp);
-// Changing condition.
-break_point_hit_count = 0;
-bp = Debug.setBreakPoint(f, 0, 0, '"ab".indexOf("b") > 0');
-f();
-assertEquals(1, break_point_hit_count);
-Debug.changeBreakPointCondition(bp, 'Math.sin(Math.PI/2) > 1');
-f();
-assertEquals(1, break_point_hit_count);
-Debug.changeBreakPointCondition(bp, '1==1');
-f();
-assertEquals(2, break_point_hit_count);
-Debug.clearBreakPoint(bp);
-
// Conditional breakpoint which checks global variable.
break_point_hit_count = 0;
bp = Debug.setBreakPoint(f, 0, 0, 'x==1');
@@ -134,21 +119,19 @@ Debug.clearBreakPoint(bp);
// Multiple conditional breakpoint which the same condition.
break_point_hit_count = 0;
bp1 = Debug.setBreakPoint(h, 0, 22, 'a % 2 == 0');
-bp2 = Debug.setBreakPoint(h, 0, 22, 'a % 2 == 0');
+assertThrows(() => Debug.setBreakPoint(h, 0, 22, 'a % 2 == 0'));
for (var i = 0; i < 10; i++) {
g();
}
assertEquals(5, break_point_hit_count);
Debug.clearBreakPoint(bp1);
-Debug.clearBreakPoint(bp2);
// Multiple conditional breakpoint which different conditions.
break_point_hit_count = 0;
bp1 = Debug.setBreakPoint(h, 0, 22, 'a % 2 == 0');
-bp2 = Debug.setBreakPoint(h, 0, 22, '(a + 1) % 2 == 0');
+assertThrows(() => Debug.setBreakPoint(h, 0, 22, '(a + 1) % 2 == 0'));
for (var i = 0; i < 10; i++) {
g();
}
-assertEquals(10, break_point_hit_count);
+assertEquals(5, break_point_hit_count);
Debug.clearBreakPoint(bp1);
-Debug.clearBreakPoint(bp2);
« no previous file with comments | « src/debug/debug-scopes.cc ('k') | test/debugger/debug/debug-evaluate-shadowed-context.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698