Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/zlib/google/zip_reader.cc

Issue 2512933002: Make ifdefs consistent in zib. (Closed)
Patch Set: Update after review. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/zlib/google/zip_reader.cc
diff --git a/third_party/zlib/google/zip_reader.cc b/third_party/zlib/google/zip_reader.cc
index fdeb1259b3a0f4d9911c2300c98223a3e0c70ca8..ff5a39514af113d28f5266d2c119d51a4d386328 100644
--- a/third_party/zlib/google/zip_reader.cc
+++ b/third_party/zlib/google/zip_reader.cc
@@ -514,11 +514,9 @@ FileWriterDelegate::FileWriterDelegate(base::File* file)
}
FileWriterDelegate::~FileWriterDelegate() {
-#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
- const bool success =
-#endif
- file_->SetLength(file_length_);
- DPLOG_IF(ERROR, !success) << "Failed updating length of written file";
+ if (!file_->SetLength(file_length_)) {
+ DPLOG(ERROR) << "Failed updating length of written file";
+ }
}
bool FileWriterDelegate::PrepareOutput() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698