Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2512933002:
Make ifdefs consistent in zib. (Closed)
|
Created:
4 years, 1 month ago by Alexander Alekseev Modified:
4 years ago Reviewers:
satorux1 CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake ifdefs consistent in zib.
Debug version of Chrome is not buildable because of inconsistent #ifdefs on
NDEBUG/ASSERT/IS_DCHECK_ON . This change makes them consistemt in zlib.
BUG=666660
Committed: https://crrev.com/90a667a18ad56d14f7068e8e6cbfb5668d3b55f3
Cr-Commit-Position: refs/heads/master@{#433729}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Update after review. #Messages
Total messages: 19 (12 generated)
alemate@chromium.org changed reviewers: + satorux@chromium.org
Please review.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2512933002/diff/1/third_party/zlib/google/zip... File third_party/zlib/google/zip_reader.cc (right): https://codereview.chromium.org/2512933002/diff/1/third_party/zlib/google/zip... third_party/zlib/google/zip_reader.cc:518: const bool success = Having a variable guarded by #ifdef looks a bit hard to read (not your fault). How about: if (!file_->SetLength(file_length_)) { DPLOG(ERROR) << "Failed updating length of written file"; }
https://codereview.chromium.org/2512933002/diff/1/third_party/zlib/google/zip... File third_party/zlib/google/zip_reader.cc (right): https://codereview.chromium.org/2512933002/diff/1/third_party/zlib/google/zip... third_party/zlib/google/zip_reader.cc:518: const bool success = On 2016/11/21 01:23:06, satorux1 wrote: > Having a variable guarded by #ifdef looks a bit hard to read (not your fault). > How about: > > if (!file_->SetLength(file_length_)) { > DPLOG(ERROR) << "Failed updating length of written file"; > } > Done.
The CQ bit was checked by alemate@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by satorux@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479777177856120,
"parent_rev": "00d236c9b5e2350cd2a512711a15c19731ef5e04", "commit_rev":
"47df8025bf93e33ae030edaa98fe8e2491379563"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make ifdefs consistent in zib. Debug version of Chrome is not buildable because of inconsistent #ifdefs on NDEBUG/ASSERT/IS_DCHECK_ON . This change makes them consistemt in zlib. BUG=666660 ========== to ========== Make ifdefs consistent in zib. Debug version of Chrome is not buildable because of inconsistent #ifdefs on NDEBUG/ASSERT/IS_DCHECK_ON . This change makes them consistemt in zlib. BUG=666660 Committed: https://crrev.com/90a667a18ad56d14f7068e8e6cbfb5668d3b55f3 Cr-Commit-Position: refs/heads/master@{#433729} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/90a667a18ad56d14f7068e8e6cbfb5668d3b55f3 Cr-Commit-Position: refs/heads/master@{#433729} |
