Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: src/objects.cc

Issue 251293002: WeakHashTable::Lookup() handlified and ObjectHashTable's interface cleaned up. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 1928d607c837bf710a18674fa18e974659c4b132..8717ea2ad134599da2b2f3a219c0cfbca1011b79 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -16065,21 +16065,6 @@ Object* ObjectHashTable::Lookup(Handle<Object> key) {
}
-// TODO(ishell): Try to remove this when FindEntry(Object* key) is removed
-int ObjectHashTable::FindEntry(Handle<Object> key) {
- return DerivedHashTable::FindEntry(key);
-}
-
-
-// TODO(ishell): Remove this when all the callers are handlified.
-int ObjectHashTable::FindEntry(Object* key) {
- DisallowHeapAllocation no_allocation;
- Isolate* isolate = GetIsolate();
- HandleScope scope(isolate);
- return FindEntry(handle(key, isolate));
-}
-
-
Handle<ObjectHashTable> ObjectHashTable::Put(Handle<ObjectHashTable> table,
Handle<Object> key,
Handle<Object> value) {
@@ -16128,29 +16113,15 @@ void ObjectHashTable::RemoveEntry(int entry) {
}
-Object* WeakHashTable::Lookup(Object* key) {
- ASSERT(IsKey(key));
+Object* WeakHashTable::Lookup(Handle<Object> key) {
+ DisallowHeapAllocation no_gc;
+ ASSERT(IsKey(*key));
int entry = FindEntry(key);
if (entry == kNotFound) return GetHeap()->the_hole_value();
return get(EntryToValueIndex(entry));
}
-// TODO(ishell): Try to remove this when FindEntry(Object* key) is removed
-int WeakHashTable::FindEntry(Handle<Object> key) {
- return DerivedHashTable::FindEntry(key);
-}
-
-
-// TODO(ishell): Remove this when all the callers are handlified.
-int WeakHashTable::FindEntry(Object* key) {
- DisallowHeapAllocation no_allocation;
- Isolate* isolate = GetIsolate();
- HandleScope scope(isolate);
- return FindEntry(handle(key, isolate));
-}
-
-
Handle<WeakHashTable> WeakHashTable::Put(Handle<WeakHashTable> table,
Handle<Object> key,
Handle<Object> value) {
« no previous file with comments | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698