Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 2512903002: Add bookmark bar/manager actions to track drag and drop. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/bookmark_manager/js/dnd.js ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index ec0a26ef567b0f0cc84466e80de9c5f478619ddc..083cac409582ef658b96a2f211109b407ed48f7d 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -1180,6 +1180,8 @@ int BookmarkBarView::OnPerformDrop(const DropTargetEvent& event) {
DCHECK(data.is_valid());
bool copy = drop_info_->location.operation == ui::DragDropTypes::DRAG_COPY;
drop_info_.reset();
+
+ content::RecordAction(base::UserMetricsAction("BookmarkBar_DragEnd"));
Alexei Svitkine (slow) 2016/11/18 16:52:15 Are you missing this in histograms.xml?
calamity 2016/11/21 00:49:58 This already exists in actions.xml, but was only i
Alexei Svitkine (slow) 2016/11/21 15:47:06 Ah, I see. It does not appear to have an owner or
calamity 2016/11/22 03:18:06 Done.
return chrome::DropBookmarks(
browser_->profile(), data, parent_node, index, copy);
}
« no previous file with comments | « chrome/browser/resources/bookmark_manager/js/dnd.js ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698