[Chrome OS MD] Update Cast and VPN to follow MD layout

ash/common/system/chromeos/network/vpn_list_view.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/chromeos/network/vpn_list_view.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 266 matching lines @@
     }
     if (UseMd()) {
       DCHECK(tri_view());
       tri_view()->AddView(TriView::Container::END, disconnect_button_);
       tri_view()->SetContainerVisible(TriView::Container::END, true);
     } else {
       AddChildView(disconnect_button_);
     }
 
     SetBorder(
-        views::CreateEmptyBorder(0, kTrayPopupPaddingHorizontal, 0,
-                                 UseMd() ? kTrayPopupButtonEndMargin : 3));
+        views::CreateEmptyBorder(0, UseMd() ? 0 : kTrayPopupPaddingHorizontal,

[bruthig, 2016/11/23 20:15:47]

Do the horizontal insets need to be updated for rows which are not
connected/connecting? i.e. on line 290?

I find it very suspicious that we are setting a border on |this| directly as
well as using a TriView for layout. Ideally it would be one or the other.

[yiyix, 2016/11/24 21:38:16]

I updated the code path such that all border changes are specific to non-md path
only. I also investigated/tried to make non-md path to use tri_view as well,
this change results removing hundred of lines. I think it would make it harder
to merge to the branch and user probably doesn't see this visual change as MD is
turned on. 

[bruthig, 2016/11/24 22:36:29]

Acknowledged.

+                                 0, UseMd() ? kTrayPopupButtonEndMargin : 3));
   } else {
     SetBorder(views::CreateEmptyBorder(0, kTrayPopupPaddingHorizontal, 0, 0));
   }
 
   if (!UseMd()) {
     // The icon and the disconnect button are always set to their preferred
     // size. All remaining space is used for the network name.
     views::BoxLayout* layout = new views::BoxLayout(
         views::BoxLayout::kHorizontal, 0, 3, kTrayPopupPaddingBetweenItems);
     SetLayoutManager(layout);
@@ skipping 192 matching lines @@
     }
   }
 
   // Add providers without any configured networks, in the order that the
   // providers were returned by the extensions system.
   for (const VPNProvider& provider : providers)
     AddProviderAndNetworks(provider.key, provider.name, networks);
 }
 
 }  // namespace ash