Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 2512873002: [DevTools] Do not use external links for resources anymore. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 587 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 case recordType.ResizeImage: 598 case recordType.ResizeImage:
599 case recordType.DecodeLazyPixelRef: 599 case recordType.DecodeLazyPixelRef:
600 case recordType.XHRReadyStateChange: 600 case recordType.XHRReadyStateChange:
601 case recordType.XHRLoad: 601 case recordType.XHRLoad:
602 case recordType.ResourceSendRequest: 602 case recordType.ResourceSendRequest:
603 case recordType.ResourceReceivedData: 603 case recordType.ResourceReceivedData:
604 case recordType.ResourceReceiveResponse: 604 case recordType.ResourceReceiveResponse:
605 case recordType.ResourceFinish: 605 case recordType.ResourceFinish:
606 var url = TimelineModel.TimelineData.forEvent(event).url; 606 var url = TimelineModel.TimelineData.forEvent(event).url;
607 if (url) 607 if (url)
608 details = Components.linkifyResourceAsNode(url); 608 details = Components.Linkifier.linkifyURL(url);
609 break; 609 break;
610 case recordType.FunctionCall: 610 case recordType.FunctionCall:
611 case recordType.JSFrame: 611 case recordType.JSFrame:
612 details = createElement('span'); 612 details = createElement('span');
613 details.createTextChild(Timeline.TimelineUIUtils.frameDisplayName(eventD ata)); 613 details.createTextChild(Timeline.TimelineUIUtils.frameDisplayName(eventD ata));
614 const location = linkifyLocation( 614 const location = linkifyLocation(
615 eventData['scriptId'], eventData['url'], eventData['lineNumber'], ev entData['columnNumber']); 615 eventData['scriptId'], eventData['url'], eventData['lineNumber'], ev entData['columnNumber']);
616 if (location) { 616 if (location) {
617 details.createTextChild(' @ '); 617 details.createTextChild(' @ ');
618 details.appendChild(location); 618 details.appendChild(location);
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
775 break; 775 break;
776 case recordTypes.FireAnimationFrame: 776 case recordTypes.FireAnimationFrame:
777 contentHelper.appendTextRow(Common.UIString('Callback ID'), eventData['i d']); 777 contentHelper.appendTextRow(Common.UIString('Callback ID'), eventData['i d']);
778 break; 778 break;
779 case recordTypes.ResourceSendRequest: 779 case recordTypes.ResourceSendRequest:
780 case recordTypes.ResourceReceiveResponse: 780 case recordTypes.ResourceReceiveResponse:
781 case recordTypes.ResourceReceivedData: 781 case recordTypes.ResourceReceivedData:
782 case recordTypes.ResourceFinish: 782 case recordTypes.ResourceFinish:
783 var url = timelineData.url; 783 var url = timelineData.url;
784 if (url) 784 if (url)
785 contentHelper.appendElementRow(Common.UIString('Resource'), Components .linkifyResourceAsNode(url)); 785 contentHelper.appendElementRow(Common.UIString('Resource'), Components .Linkifier.linkifyURL(url));
786 if (eventData['requestMethod']) 786 if (eventData['requestMethod'])
787 contentHelper.appendTextRow(Common.UIString('Request Method'), eventDa ta['requestMethod']); 787 contentHelper.appendTextRow(Common.UIString('Request Method'), eventDa ta['requestMethod']);
788 if (typeof eventData['statusCode'] === 'number') 788 if (typeof eventData['statusCode'] === 'number')
789 contentHelper.appendTextRow(Common.UIString('Status Code'), eventData[ 'statusCode']); 789 contentHelper.appendTextRow(Common.UIString('Status Code'), eventData[ 'statusCode']);
790 if (eventData['mimeType']) 790 if (eventData['mimeType'])
791 contentHelper.appendTextRow(Common.UIString('MIME Type'), eventData['m imeType']); 791 contentHelper.appendTextRow(Common.UIString('MIME Type'), eventData['m imeType']);
792 if ('priority' in eventData) { 792 if ('priority' in eventData) {
793 var priority = Components.uiLabelForPriority(eventData['priority']); 793 var priority = Components.uiLabelForPriority(eventData['priority']);
794 contentHelper.appendTextRow(Common.UIString('Priority'), priority); 794 contentHelper.appendTextRow(Common.UIString('Priority'), priority);
795 } 795 }
(...skipping 24 matching lines...) Expand all
820 relatedNodeLabel = Common.UIString('Layer Root'); 820 relatedNodeLabel = Common.UIString('Layer Root');
821 break; 821 break;
822 case recordTypes.PaintImage: 822 case recordTypes.PaintImage:
823 case recordTypes.DecodeLazyPixelRef: 823 case recordTypes.DecodeLazyPixelRef:
824 case recordTypes.DecodeImage: 824 case recordTypes.DecodeImage:
825 case recordTypes.ResizeImage: 825 case recordTypes.ResizeImage:
826 case recordTypes.DrawLazyPixelRef: 826 case recordTypes.DrawLazyPixelRef:
827 relatedNodeLabel = Common.UIString('Owner Element'); 827 relatedNodeLabel = Common.UIString('Owner Element');
828 if (timelineData.url) { 828 if (timelineData.url) {
829 contentHelper.appendElementRow( 829 contentHelper.appendElementRow(
830 Common.UIString('Image URL'), Components.linkifyResourceAsNode(tim elineData.url)); 830 Common.UIString('Image URL'), Components.Linkifier.linkifyURL(time lineData.url));
831 } 831 }
832 break; 832 break;
833 case recordTypes.ParseAuthorStyleSheet: 833 case recordTypes.ParseAuthorStyleSheet:
834 var url = eventData['styleSheetUrl']; 834 var url = eventData['styleSheetUrl'];
835 if (url) 835 if (url)
836 contentHelper.appendElementRow(Common.UIString('Stylesheet URL'), Comp onents.linkifyResourceAsNode(url)); 836 contentHelper.appendElementRow(Common.UIString('Stylesheet URL'), Comp onents.Linkifier.linkifyURL(url));
837 break; 837 break;
838 case recordTypes.UpdateLayoutTree: // We don't want to see default detail s. 838 case recordTypes.UpdateLayoutTree: // We don't want to see default detail s.
839 case recordTypes.RecalculateStyles: 839 case recordTypes.RecalculateStyles:
840 contentHelper.appendTextRow(Common.UIString('Elements Affected'), event. args['elementCount']); 840 contentHelper.appendTextRow(Common.UIString('Elements Affected'), event. args['elementCount']);
841 break; 841 break;
842 case recordTypes.Layout: 842 case recordTypes.Layout:
843 var beginData = event.args['beginData']; 843 var beginData = event.args['beginData'];
844 contentHelper.appendTextRow( 844 contentHelper.appendTextRow(
845 Common.UIString('Nodes That Need Layout'), 845 Common.UIString('Nodes That Need Layout'),
846 Common.UIString('%s of %s', beginData['dirtyObjects'], beginData['to talObjects'])); 846 Common.UIString('%s of %s', beginData['dirtyObjects'], beginData['to talObjects']));
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
1018 * @param {!Components.Linkifier} linkifier 1018 * @param {!Components.Linkifier} linkifier
1019 * @return {!Promise<!DocumentFragment>} 1019 * @return {!Promise<!DocumentFragment>}
1020 */ 1020 */
1021 static buildNetworkRequestDetails(request, model, linkifier) { 1021 static buildNetworkRequestDetails(request, model, linkifier) {
1022 var target = model.targetByEvent(request.children[0]); 1022 var target = model.targetByEvent(request.children[0]);
1023 var contentHelper = new Timeline.TimelineDetailsContentHelper(target, linkif ier); 1023 var contentHelper = new Timeline.TimelineDetailsContentHelper(target, linkif ier);
1024 1024
1025 var duration = request.endTime - (request.startTime || -Infinity); 1025 var duration = request.endTime - (request.startTime || -Infinity);
1026 var items = []; 1026 var items = [];
1027 if (request.url) 1027 if (request.url)
1028 contentHelper.appendElementRow(Common.UIString('URL'), Components.Linkifie r.linkifyURLAsNode(request.url)); 1028 contentHelper.appendElementRow(Common.UIString('URL'), Components.Linkifie r.linkifyURL(request.url));
1029 if (isFinite(duration)) 1029 if (isFinite(duration))
1030 contentHelper.appendTextRow(Common.UIString('Duration'), Number.millisToSt ring(duration, true)); 1030 contentHelper.appendTextRow(Common.UIString('Duration'), Number.millisToSt ring(duration, true));
1031 if (request.requestMethod) 1031 if (request.requestMethod)
1032 contentHelper.appendTextRow(Common.UIString('Request Method'), request.req uestMethod); 1032 contentHelper.appendTextRow(Common.UIString('Request Method'), request.req uestMethod);
1033 if (typeof request.priority === 'string') { 1033 if (typeof request.priority === 'string') {
1034 var priority = 1034 var priority =
1035 Components.uiLabelForPriority(/** @type {!Protocol.Network.ResourcePri ority} */ (request.priority)); 1035 Components.uiLabelForPriority(/** @type {!Protocol.Network.ResourcePri ority} */ (request.priority));
1036 contentHelper.appendTextRow(Common.UIString('Priority'), priority); 1036 contentHelper.appendTextRow(Common.UIString('Priority'), priority);
1037 } 1037 }
1038 if (request.mimeType) 1038 if (request.mimeType)
(...skipping 1194 matching lines...) Expand 10 before | Expand all | Expand 10 after
2233 /** 2233 /**
2234 * @param {!SDK.TracingModel.Event} event 2234 * @param {!SDK.TracingModel.Event} event
2235 * @param {string=} warningType 2235 * @param {string=} warningType
2236 */ 2236 */
2237 appendWarningRow(event, warningType) { 2237 appendWarningRow(event, warningType) {
2238 var warning = Timeline.TimelineUIUtils.eventWarning(event, warningType); 2238 var warning = Timeline.TimelineUIUtils.eventWarning(event, warningType);
2239 if (warning) 2239 if (warning)
2240 this.appendElementRow(Common.UIString('Warning'), warning, true); 2240 this.appendElementRow(Common.UIString('Warning'), warning, true);
2241 } 2241 }
2242 }; 2242 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698