Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2512863002: Fix nits in base/base_paths_posix.cc (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nits in base/base_paths_posix.cc Committed: https://crrev.com/bf8ab1bff06ae74998492c4d5ad1dc923fef84bf Cr-Commit-Position: refs/heads/master@{#433398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M base/base_paths_posix.cc View 3 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Lei Zhang
4 years, 1 month ago (2016-11-19 01:33:07 UTC) #6
Dan Beam
if only somebody wrote a script to do this un base::'ing! lgtm
4 years, 1 month ago (2016-11-19 01:45:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512863002/1
4 years, 1 month ago (2016-11-19 01:49:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 04:16:52 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 04:19:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf8ab1bff06ae74998492c4d5ad1dc923fef84bf
Cr-Commit-Position: refs/heads/master@{#433398}

Powered by Google App Engine
This is Rietveld 408576698