[wasm] Translate locations to positions properly

[wasm] Translate locations to positions properly

... at least for the function which will remain after restructuring of
the debug interface. For some methods that will be removed anyway, we
just return zero / null for now.

I also refactored the ScriptLocationFromLine method to make it more
readable and reuse parts in other files (like ScriptLinePosition).

BUG=5655
R=titzer@chromium.org, jgruber@chromium.org

Committed: https://crrev.com/8ab945f2e087f8686bd3a2ef40c9201120b2d4ef
Cr-Commit-Position: refs/heads/master@{#41115}

[Clemens Hammacher, 2016-11-18 12:59:37]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 12:59:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-11-18 13:01:26]

I would actually propose to make the ScriptLinePosition function a method on the
Script.
Jakob, WDYT?

[commit-bot: I haz the power, 2016-11-18 13:27:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 13:27:32]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-11-18 13:57:35]

Nice, lgtm with nit.

https://codereview.chromium.org/2512833003/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/2512833003/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1625: if (line > line_count) return -1;
The old code also handles negative values of 'line', should we do that here as
well?

[Clemens Hammacher, 2016-11-18 14:02:52]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 14:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Clemens Hammacher, 2016-11-18 14:14:29]

https://codereview.chromium.org/2512833003/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/2512833003/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1625: if (line > line_count) return -1;
On 2016/11/18 at 13:57:35, jgruber wrote:
> The old code also handles negative values of 'line', should we do that here as
well?

Done.

[commit-bot: I haz the power, 2016-11-18 14:28:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 14:28:28]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-11-18 14:29:12]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-11-18 14:29:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2512833003/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2016-11-18 14:29:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 14:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 14:32:49]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28901)

[Clemens Hammacher, 2016-11-18 14:40:14]

On 2016/11/18 at 14:32:49, commit-bot wrote:
> Try jobs failed on following builders:
>   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28901)

Oh, you are also no owner yet :)

Have to wait for Ben anyway for the wasm stuff.

[titzer, 2016-11-18 14:44:01]

On 2016/11/18 14:40:14, Clemens Hammacher wrote:
> On 2016/11/18 at 14:32:49, commit-bot wrote:
> > Try jobs failed on following builders:
> >   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28901)
> 
> Oh, you are also no owner yet :)
> 
> Have to wait for Ben anyway for the wasm stuff.

lgtm

[Clemens Hammacher, 2016-11-18 15:02:05]

The CQ bit was checked by clemensh@chromium.org

[commit-bot: I haz the power, 2016-11-18 15:02:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 15:04:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 15:04:59]

Description was changed from

==========
[wasm] Translate locations to positions properly

... at least for the function which will remain after restructuring of
the debug interface. For some methods that will be removed anyway, we
just return zero / null for now.

I also refactored the ScriptLocationFromLine method to make it more
readable and reuse parts in other files (like ScriptLinePosition).

BUG=5655
R=titzer@chromium.org, jgruber@chromium.org
==========

to

==========
[wasm] Translate locations to positions properly

... at least for the function which will remain after restructuring of
the debug interface. For some methods that will be removed anyway, we
just return zero / null for now.

I also refactored the ScriptLocationFromLine method to make it more
readable and reuse parts in other files (like ScriptLinePosition).

BUG=5655
R=titzer@chromium.org, jgruber@chromium.org

Committed: https://crrev.com/8ab945f2e087f8686bd3a2ef40c9201120b2d4ef
Cr-Commit-Position: refs/heads/master@{#41115}
==========

[commit-bot: I haz the power, 2016-11-18 15:05:05]

Patchset 2 (id:??) landed as
https://crrev.com/8ab945f2e087f8686bd3a2ef40c9201120b2d4ef
Cr-Commit-Position: refs/heads/master@{#41115}