Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2512823002: Add comment to the PaymentRequest feature (Closed)

Created:
4 years, 1 month ago by Rick Byers
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comment to the PaymentRequest feature It's enabled by default on Android by content_features.cc and SetRuntimeFeaturesDefaultsAndUpdateFromArgs. NOTRY=true Committed: https://crrev.com/a7a49f63e90da3665424408bbaf4ce865312a713 Cr-Commit-Position: refs/heads/master@{#433054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Rick Byers
I was confused thinking HTMLIFrameElement.paymentrequestenabled hadn't shipped yet since it was labeled as [RuntimeEnabled=PaymentRequest] which ...
4 years, 1 month ago (2016-11-17 22:36:40 UTC) #2
please use gerrit instead
lgtm
4 years, 1 month ago (2016-11-17 22:41:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512823002/1
4 years, 1 month ago (2016-11-17 22:43:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/194583)
4 years, 1 month ago (2016-11-18 00:22:13 UTC) #7
Rick Byers
On 2016/11/18 00:22:13, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-11-18 01:30:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512823002/1
4 years, 1 month ago (2016-11-18 01:31:19 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 03:21:21 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 03:25:27 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7a49f63e90da3665424408bbaf4ce865312a713
Cr-Commit-Position: refs/heads/master@{#433054}

Powered by Google App Engine
This is Rietveld 408576698