|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by Rick Byers Modified:
4 years, 1 month ago Reviewers:
please use gerrit instead CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd comment to the PaymentRequest feature
It's enabled by default on Android by content_features.cc and
SetRuntimeFeaturesDefaultsAndUpdateFromArgs.
NOTRY=true
Committed: https://crrev.com/a7a49f63e90da3665424408bbaf4ce865312a713
Cr-Commit-Position: refs/heads/master@{#433054}
Patch Set 1 #
Messages
Total messages: 16 (8 generated)
rbyers@chromium.org changed reviewers: + rouslan@chromium.org
I was confused thinking HTMLIFrameElement.paymentrequestenabled hadn't shipped yet since it was labeled as [RuntimeEnabled=PaymentRequest] which is listed as 'experimental' and it didn't show up in virtual/stable/webexposed/element-instance-property-listing-expected.txt (crbug.com/666495). Let's at least add a comment (like for WebBluetooth) to make it clear it HAS shipped despite being "status=experimental".
The CQ bit was checked by rouslan@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Add comment to the PaymentRequest feature It's enabled by default on Android by content_features.cc and SetRuntimeFeaturesDefaultsAndUpdateFromArgs. ========== to ========== Add comment to the PaymentRequest feature It's enabled by default on Android by content_features.cc and SetRuntimeFeaturesDefaultsAndUpdateFromArgs. NOTRY=TRUE ==========
Description was changed from ========== Add comment to the PaymentRequest feature It's enabled by default on Android by content_features.cc and SetRuntimeFeaturesDefaultsAndUpdateFromArgs. NOTRY=TRUE ========== to ========== Add comment to the PaymentRequest feature It's enabled by default on Android by content_features.cc and SetRuntimeFeaturesDefaultsAndUpdateFromArgs. NOTRY=true ==========
On 2016/11/18 00:22:13, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Comment-only change, passed build on most bots, hit two different flakes. Landing with NOTRY.
The CQ bit was checked by rbyers@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add comment to the PaymentRequest feature It's enabled by default on Android by content_features.cc and SetRuntimeFeaturesDefaultsAndUpdateFromArgs. NOTRY=true ========== to ========== Add comment to the PaymentRequest feature It's enabled by default on Android by content_features.cc and SetRuntimeFeaturesDefaultsAndUpdateFromArgs. NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add comment to the PaymentRequest feature It's enabled by default on Android by content_features.cc and SetRuntimeFeaturesDefaultsAndUpdateFromArgs. NOTRY=true ========== to ========== Add comment to the PaymentRequest feature It's enabled by default on Android by content_features.cc and SetRuntimeFeaturesDefaultsAndUpdateFromArgs. NOTRY=true Committed: https://crrev.com/a7a49f63e90da3665424408bbaf4ce865312a713 Cr-Commit-Position: refs/heads/master@{#433054} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a7a49f63e90da3665424408bbaf4ce865312a713 Cr-Commit-Position: refs/heads/master@{#433054} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
