Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 2512793004: [ObjC ARC] Converts ios/chrome/browser/suggestions:unit_tests to ARC.Automatically generated ARCM… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/suggestions:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/eb695127d97eb9847ef9c06e92de7e8c662224f7 Cr-Commit-Position: refs/heads/master@{#433560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/suggestions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/suggestions/ios_image_decoder_impl_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 13:03:52 UTC) #6
noyau (Ping after 24h)
lgtm
4 years, 1 month ago (2016-11-21 14:19:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512793004/1
4 years, 1 month ago (2016-11-21 15:39:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 16:36:30 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 16:40:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb695127d97eb9847ef9c06e92de7e8c662224f7
Cr-Commit-Position: refs/heads/master@{#433560}

Powered by Google App Engine
This is Rietveld 408576698