Throw RangeError for invalid refDistance/maxDistance

Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.

BUG=666396
TEST=panner-distance-clamping.html

Committed: https://crrev.com/3d0b06fe16bd256cc1dbe768d5b6d43c20f3f1ec
Cr-Commit-Position: refs/heads/master@{#435993}

[Raymond Toy, 2016-11-17 21:27:45]

Description was changed from

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.

Also, the PannerOptions dictionary incorrectly declared several
members as being floats instead of doubles.  We correct that here as
well and add tests that to check that the values are actually
implemented as doubles.  This includes a check for the position
AudioParams which should be stored as floats.

BUG=658599
TEST=panner-distance-clamping.html updated
==========

to

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.

Also, the PannerOptions dictionary incorrectly declared several
members as being floats instead of doubles.  We correct that here as
well and add tests that to check that the values are actually
implemented as doubles.  This includes a check for the position
AudioParams which should be stored as floats.

BUG=658599, 666471
TEST=panner-distance-clamping.html, constructor/panner.html updated
==========

[Raymond Toy, 2016-11-17 21:28:29]

Description was changed from

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.

Also, the PannerOptions dictionary incorrectly declared several
members as being floats instead of doubles.  We correct that here as
well and add tests that to check that the values are actually
implemented as doubles.  This includes a check for the position
AudioParams which should be stored as floats.

BUG=658599, 666471
TEST=panner-distance-clamping.html, constructor/panner.html updated
==========

to

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.

Also, the PannerOptions dictionary incorrectly declared several
members as being floats instead of doubles.  We correct that here as
well and add tests to check that the values are actually
implemented as doubles.  This includes a check for the position
AudioParams which should be stored as floats.

BUG=658599, 666471
TEST=panner-distance-clamping.html, constructor/panner.html updated
==========

[Raymond Toy, 2016-11-17 21:29:50]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 21:31:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-11-17 22:38:13]

Description was changed from

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.

Also, the PannerOptions dictionary incorrectly declared several
members as being floats instead of doubles.  We correct that here as
well and add tests to check that the values are actually
implemented as doubles.  This includes a check for the position
AudioParams which should be stored as floats.

BUG=658599, 666471
TEST=panner-distance-clamping.html, constructor/panner.html updated
==========

to

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.


BUG=658599
TEST=panner-distance-clamping.html
==========

[Raymond Toy, 2016-11-17 22:39:00]

Patchset #1 (id:1) has been deleted

[Raymond Toy, 2016-11-17 22:42:02]

Description was changed from

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.


BUG=658599
TEST=panner-distance-clamping.html
==========

to

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.


BUG=666396
TEST=panner-distance-clamping.html
==========

[Raymond Toy, 2016-11-28 20:12:52]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 20:13:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 22:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 22:26:24]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-11-28 23:27:58]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-11-28 23:27:58]

PTAL

[hongchan, 2016-12-02 17:51:24]

lgtm, but I guess we have to rewrite the test with the new test utility later.

[Raymond Toy, 2016-12-02 17:56:44]

On 2016/12/02 17:51:24, hongchan wrote:
> lgtm, but I guess we have to rewrite the test with the new test utility later.

Yep.

[Raymond Toy, 2016-12-02 17:57:06]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-12-02 17:57:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 19:29:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480701426740770,
"parent_rev": "5523a73eacf9ae75e099ee66f6f8af05611b877e", "commit_rev":
"a695f8d2408686b92106300c3136f08f548ee053"}

[commit-bot: I haz the power, 2016-12-02 19:30:18]

Description was changed from

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.


BUG=666396
TEST=panner-distance-clamping.html
==========

to

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.


BUG=666396
TEST=panner-distance-clamping.html
==========

[commit-bot: I haz the power, 2016-12-02 19:30:22]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-12-02 19:33:14]

Description was changed from

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.


BUG=666396
TEST=panner-distance-clamping.html
==========

to

==========
Throw RangeError for invalid refDistance/maxDistance

The PannerNode refDistance and maxDistance attributes must throw a
RangeError on attempts to set either to a non-positive value.

BUG=666396
TEST=panner-distance-clamping.html

Committed: https://crrev.com/3d0b06fe16bd256cc1dbe768d5b6d43c20f3f1ec
Cr-Commit-Position: refs/heads/master@{#435993}
==========

[commit-bot: I haz the power, 2016-12-02 19:33:15]

Patchset 4 (id:??) landed as
https://crrev.com/3d0b06fe16bd256cc1dbe768d5b6d43c20f3f1ec
Cr-Commit-Position: refs/heads/master@{#435993}