Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 25127002: Use production Wallet service URL by default. (Closed)

Created:
7 years, 2 months ago by Dan Beam
Modified:
5 years, 4 months ago
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org, groby-ooo-7-16, aruslan
Visibility:
Public.

Description

Use production Wallet service URL by default. Also change --wallet-service-use-prod to --wallet-service-use-sandbox instead (and update about:flags description). BUG=299902 R=estade@chromium.org TEST=unit_tests, no developer warning/real generated cards by default Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226123

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : estade@ review #

Patch Set 3 : nix Online #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -36 lines) Patch
M build/ios/grit_whitelist.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 2 3 2 chunks +16 lines, -9 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_service_url.cc View 1 2 3 1 chunk +10 lines, -3 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_service_url_unittest.cc View 1 2 3 2 chunks +47 lines, -9 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Dan Beam
CC'd as an FYI: +groby@: adding sandbox flag to Mac as well +aruslan@: talked with ...
7 years, 2 months ago (2013-09-27 23:51:40 UTC) #1
groby-ooo-7-16
Fine with me - but given that Mac is still sort-of behind a flag, should ...
7 years, 2 months ago (2013-09-27 23:53:57 UTC) #2
Dan Beam
On 2013/09/27 23:53:57, groby wrote: > Fine with me - but given that Mac is ...
7 years, 2 months ago (2013-09-27 23:58:31 UTC) #3
Evan Stade
I agree that Mac should be sandboxed by default. https://codereview.chromium.org/25127002/diff/3001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/25127002/diff/3001/chrome/app/generated_resources.grd#newcode5953 chrome/app/generated_resources.grd:5953: ...
7 years, 2 months ago (2013-09-28 00:36:45 UTC) #4
Dan Beam
also made sandbox the default on Mac https://codereview.chromium.org/25127002/diff/3001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/25127002/diff/3001/chrome/app/generated_resources.grd#newcode5953 chrome/app/generated_resources.grd:5953: + Use ...
7 years, 2 months ago (2013-09-28 01:34:26 UTC) #5
Evan Stade
lgtm
7 years, 2 months ago (2013-09-30 18:45:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/25127002/19001
7 years, 2 months ago (2013-09-30 18:50:51 UTC) #7
commit-bot: I haz the power
Change committed as 226123
7 years, 2 months ago (2013-10-01 03:22:33 UTC) #8
MegaMyFunLiFe
5 years, 4 months ago (2015-08-02 23:18:43 UTC) #10
Message was sent while issue was closed.
<a href="http://affiliate.trustcard.vn/affiliate/affiliate.php?id=5516&group=1"
title="- Gioi thieu the TRUSTcard
- Định dạng jpeg
- Kích thước 250x250
- Dung lượng 36.0 KB" target="_blank"><img
src="http://affiliate.trustcard.vn/banners/imgcontainer.php?group_id=1&banner_id=4&aff_id=5516"
width="250" height="250" border="0" alt="" /></a>

Powered by Google App Engine
This is Rietveld 408576698