Create ImageDecoder target color space

Create ImageDecoder target color space

This is towards allowing us to specify the transform that we want
applied to the image as it is decoded, as opposed to getting whatever
the global transform is.

This does not change any behavior.

BUG=667420
Committed: https://crrev.com/06f9ccab7e622c578258288e38554c05ec9a8dab
Cr-Commit-Position: refs/heads/master@{#433781}

[ccameron, 2016-11-18 17:50:51]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 17:51:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 19:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 19:34:06]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-11-20 00:29:40]

ccameron@chromium.org changed reviewers:
+ esprehn@chromium.org

[ccameron, 2016-11-20 00:29:40]

ptal -- this is just reshuffling and renaming.

In the future we'll want to be able to vary this, but for now we just want to be
more explicit about the fun global variable mess that we're in.

[ccameron, 2016-11-21 19:11:28]

Description was changed from

==========
Create ImageDecoder target color space

This is towards allowing us to specify the transform that we want
applied to the image as it is decoded, as opposed to getting whatever
the global transform is.

This does not change any behavior.

BUG=44872
==========

to

==========
Create ImageDecoder target color space

This is towards allowing us to specify the transform that we want
applied to the image as it is decoded, as opposed to getting whatever
the global transform is.

This does not change any behavior.

BUG=667420
==========

[esprehn, 2016-11-21 20:19:30]

https://codereview.chromium.org/2512683003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right):

https://codereview.chromium.org/2512683003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:214: static
void setGlobalTargetColorProfile(const WebVector<char>&);
Since this isn't part of the public API we'd normally use a WTF::Vector instead.

https://codereview.chromium.org/2512683003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/2512683003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebViewImpl.cpp:3048:
ImageDecoder::setGlobalTargetColorProfile(deviceProfile);
This is forcing a copy to convert from WTF::Vector to WebVector here. The
setGlobalTargetColorProfile method should really take a Vector, or just pass the
colorProfile  variable directly?

[ccameron, 2016-11-21 22:28:14]

Updated

https://codereview.chromium.org/2512683003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right):

https://codereview.chromium.org/2512683003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:214: static
void setGlobalTargetColorProfile(const WebVector<char>&);
On 2016/11/21 20:19:30, esprehn wrote:
> Since this isn't part of the public API we'd normally use a WTF::Vector
instead.

I changed the caller to just pass in its WebVector directly -- does that look
better?

https://codereview.chromium.org/2512683003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/2512683003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebViewImpl.cpp:3048:
ImageDecoder::setGlobalTargetColorProfile(deviceProfile);
On 2016/11/21 20:19:30, esprehn wrote:
> This is forcing a copy to convert from WTF::Vector to WebVector here. The
> setGlobalTargetColorProfile method should really take a Vector, or just pass
the
> colorProfile  variable directly?

Updated to pass colorProfile directly (I wonder why it wasn't...).

[esprehn, 2016-11-21 22:35:14]

lgtm

[ccameron, 2016-11-21 23:45:34]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-11-21 23:46:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-11-21 23:51:26]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2016-11-21 23:51:26]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-11-21 23:51:27]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2016-11-21 23:53:54]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 23:54:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 00:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 00:05:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-11-22 02:27:43]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-11-22 02:27:43]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2512683003/#ps40001
(title: "Fix mid-air collision with 
https://codereview.chromium.org/2483243003")

[commit-bot: I haz the power, 2016-11-22 02:28:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 03:53:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479781663502810,
"parent_rev": "82b3f7a0f2e4c62daf4020c26e4d0b53a6a30ca3", "commit_rev":
"c123531d4a3ca0f2edb5cf6a5116050f8b157295"}

[commit-bot: I haz the power, 2016-11-22 03:54:07]

Description was changed from

==========
Create ImageDecoder target color space

This is towards allowing us to specify the transform that we want
applied to the image as it is decoded, as opposed to getting whatever
the global transform is.

This does not change any behavior.

BUG=667420
==========

to

==========
Create ImageDecoder target color space

This is towards allowing us to specify the transform that we want
applied to the image as it is decoded, as opposed to getting whatever
the global transform is.

This does not change any behavior.

BUG=667420
==========

[commit-bot: I haz the power, 2016-11-22 03:54:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-22 03:58:16]

Description was changed from

==========
Create ImageDecoder target color space

This is towards allowing us to specify the transform that we want
applied to the image as it is decoded, as opposed to getting whatever
the global transform is.

This does not change any behavior.

BUG=667420
==========

to

==========
Create ImageDecoder target color space

This is towards allowing us to specify the transform that we want
applied to the image as it is decoded, as opposed to getting whatever
the global transform is.

This does not change any behavior.

BUG=667420

Committed: https://crrev.com/06f9ccab7e622c578258288e38554c05ec9a8dab
Cr-Commit-Position: refs/heads/master@{#433781}
==========

[commit-bot: I haz the power, 2016-11-22 03:58:17]

Patchset 3 (id:??) landed as
https://crrev.com/06f9ccab7e622c578258288e38554c05ec9a8dab
Cr-Commit-Position: refs/heads/master@{#433781}