Issue 2512653003: Fix nullptr exception on ios_internal

Issue 2512653003: Fix nullptr exception on ios_internal (Closed)

Created:
4 years, 1 month ago by Olivier

Modified:
4 years, 1 month ago

Reviewers:
jif, jif-google

CC:
chromium-reviews, sdefresne+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix nullptr exception on ios_internal BUG=661668 Committed: https://crrev.com/2a006f7420305db8a069bcc747d4bc343e47f702 Cr-Commit-Position: refs/heads/master@{#432860}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	ios/chrome/browser/reading_list/reading_list_model_factory.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	ios/chrome/browser/reading_list/reading_list_model_factory.cc	View		2 chunks	+5 lines, -6 lines	0 comments	Download

Total messages: 12 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512653003/1

4 years, 1 month ago (2016-11-17 13:50:21 UTC) #7

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/2a006f7420305db8a069bcc747d4bc343e47f702 Cr-Commit-Position: refs/heads/master@{#432860}

4 years, 1 month ago (2016-11-17 14:03:12 UTC) #10

Matt Giuca

A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2506183004/ by mgiuca@chromium.org. ...

4 years, 1 month ago (2016-11-18 02:08:40 UTC) #11

Message was sent while issue was closed.

LGTM.
Reladed as part of the reland of the other CL.