Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: test/cctest/heap/test-incremental-marking.cc

Issue 2512643002: [heap] Remove out of date IncrementalMarkingUsingIdleTasksAfterGC test. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-incremental-marking.cc
diff --git a/test/cctest/heap/test-incremental-marking.cc b/test/cctest/heap/test-incremental-marking.cc
index c659cecea7aaac601044314d5312d9b554c50c65..642a3584e785815d6331356cff759485ea04a210 100644
--- a/test/cctest/heap/test-incremental-marking.cc
+++ b/test/cctest/heap/test-incremental-marking.cc
@@ -57,7 +57,7 @@ class MockPlatform : public v8::Platform {
platform_->CallIdleOnForegroundThread(isolate, task);
}
- bool IdleTasksEnabled(v8::Isolate* isolate) override { return true; }
+ bool IdleTasksEnabled(v8::Isolate* isolate) override { return false; }
bool PendingTask() { return task_ != nullptr; }
@@ -114,31 +114,5 @@ TEST(IncrementalMarkingUsingTasks) {
i::V8::SetPlatformForTesting(old_platform);
}
-
-TEST(IncrementalMarkingUsingIdleTasksAfterGC) {
- if (!i::FLAG_incremental_marking) return;
-
- CcTest::InitializeVM();
- v8::Platform* old_platform = i::V8::GetCurrentPlatform();
- MockPlatform platform(old_platform);
- i::V8::SetPlatformForTesting(&platform);
- i::heap::SimulateFullSpace(CcTest::heap()->old_space());
- CcTest::CollectAllGarbage(i::Heap::kFinalizeIncrementalMarkingMask);
- // Perform any pending idle tasks.
- while (platform.PendingTask()) {
- platform.PerformTask();
- }
- CHECK(!platform.PendingTask());
- i::IncrementalMarking* marking = CcTest::heap()->incremental_marking();
- marking->Stop();
- marking->Start(i::GarbageCollectionReason::kTesting);
- CHECK(platform.PendingTask());
- while (platform.PendingTask()) {
- platform.PerformTask();
- }
- CHECK(marking->IsStopped());
- i::V8::SetPlatformForTesting(old_platform);
-}
-
} // namespace internal
} // namespace v8
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698