Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2512633002: Add stubs for requests that currently crash Analysis Server with the new analysis driver. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add stubs for requests that currently crash Analysis Server with the new analysis driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5acc4aba69e8c2971ea8a892b0588383c83e1bde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-17 06:09:57 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-17 14:15:00 UTC) #2
scheglov
4 years, 1 month ago (2016-11-17 16:16:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5acc4aba69e8c2971ea8a892b0588383c83e1bde (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698