Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: src/string-stream.cc

Issue 251263004: Handlification TODOs in scanner and string stream resolved. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/scanner.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/string-stream.cc
diff --git a/src/string-stream.cc b/src/string-stream.cc
index e9795adde3653dacd29aad04ea115c4f91293418..25e340b4a563323f7a830ee73033161572906bb3 100644
--- a/src/string-stream.cc
+++ b/src/string-stream.cc
@@ -265,14 +265,8 @@ void StringStream::OutputToFile(FILE* out) {
Handle<String> StringStream::ToString(Isolate* isolate) {
- MaybeHandle<String> maybe_result = isolate->factory()->NewStringFromUtf8(
- Vector<const char>(buffer_, length_));
-
- // TODO(ishell): Temporarily returning null handle from here. I will proceed
- // with maybehandlification in next CLs.
- Handle<String> result;
- if (!maybe_result.ToHandle(&result)) return Handle<String>();
- return result;
+ return isolate->factory()->NewStringFromUtf8(
+ Vector<const char>(buffer_, length_)).ToHandleChecked();
}
« no previous file with comments | « src/scanner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698