Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: src/scanner.cc

Issue 251263004: Handlification TODOs in scanner and string stream resolved. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/string-stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scanner.cc
diff --git a/src/scanner.cc b/src/scanner.cc
index d09dbb9922e024a6e04015cf63a2ef1434ba4e6c..4ad0f4118dee769bd72c369532f38cea8b0b25bf 100644
--- a/src/scanner.cc
+++ b/src/scanner.cc
@@ -1095,19 +1095,13 @@ bool Scanner::ScanRegExpFlags() {
Handle<String> Scanner::AllocateNextLiteralString(Isolate* isolate,
PretenureFlag tenured) {
- MaybeHandle<String> maybe_result;
if (is_next_literal_one_byte()) {
- maybe_result = isolate->factory()->NewStringFromOneByte(
- next_literal_one_byte_string(), tenured);
+ return isolate->factory()->NewStringFromOneByte(
+ next_literal_one_byte_string(), tenured).ToHandleChecked();
} else {
- maybe_result = isolate->factory()->NewStringFromTwoByte(
- next_literal_two_byte_string(), tenured);
+ return isolate->factory()->NewStringFromTwoByte(
+ next_literal_two_byte_string(), tenured).ToHandleChecked();
}
- // TODO(ishell): Temporarily returning null handle from here. I will proceed
- // with maybehandlification in next CLs.
- Handle<String> result;
- if (!maybe_result.ToHandle(&result)) return Handle<String>();
- return result;
}
« no previous file with comments | « no previous file | src/string-stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698