Issue 251263004: Handlification TODOs in scanner and string stream resolved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251263004: Handlification TODOs in scanner and string stream resolved. (Closed)

Created:
6 years, 7 months ago by Igor Sheludko

Modified:
6 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Handlification TODOs in scanner and string stream resolved. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21081

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -18 lines)			Patch
	M	src/scanner.cc	View		1 chunk	+4 lines, -10 lines	0 comments	Download
	M	src/string-stream.cc	View		1 chunk	+2 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

On 2014/04/29 14:20:10, Igor Sheludko wrote: > PTAL #7 lgtm.

6 years, 7 months ago (2014-04-29 14:20:57 UTC) #2

Igor Sheludko

6 years, 7 months ago (2014-04-30 09:13:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21081 (presubmit successful).