Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 251263002: test_runner: Move three Mock* files into content namespace. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

test_runner: Move three Mock* files into content namespace. BUG=331299 TEST=None, no functional changes. Green trybots to make sure content_shell, content_unittests, content_browsertests still link. TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M content/shell/renderer/test_runner/MockColorChooser.h View 2 chunks +9 lines, -9 lines 0 comments Download
M content/shell/renderer/test_runner/MockColorChooser.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/MockConstraints.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockConstraints.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockGrammarCheck.h View 2 chunks +3 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/MockGrammarCheck.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebRTCPeerConnectionHandler.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/WebUserMediaClientMock.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
TBRing... My plan is to get everything into content namespace, then fix the file names, ...
6 years, 7 months ago (2014-04-29 04:37:21 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-04-29 04:37:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/251263002/1
6 years, 7 months ago (2014-04-29 04:38:09 UTC) #3
tfarina
I noticed you commented about the "using namespace ...". This will go away in the ...
6 years, 7 months ago (2014-04-29 04:38:17 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 11:07:26 UTC) #5
Message was sent while issue was closed.
Change committed as 266839

Powered by Google App Engine
This is Rietveld 408576698