Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2512613005: [ObjC ARC] Converts ios/chrome/common/physical_web:physical_web to ARC.Automatically generated AR… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
Reviewers:
Olivier
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/common/physical_web:physical_web to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/bf44e6ae2555a4a3e27562ea1a3d8b266df10458 Cr-Commit-Position: refs/heads/master@{#433609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -26 lines) Patch
M ios/chrome/common/physical_web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/common/physical_web/physical_web_device.h View 2 chunks +6 lines, -6 lines 0 comments Download
M ios/chrome/common/physical_web/physical_web_device.mm View 3 chunks +9 lines, -5 lines 0 comments Download
M ios/chrome/common/physical_web/physical_web_request.mm View 6 chunks +10 lines, -7 lines 0 comments Download
M ios/chrome/common/physical_web/physical_web_scanner.mm View 4 chunks +11 lines, -8 lines 0 comments Download
M ios/chrome/common/physical_web/physical_web_types.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 11:57:17 UTC) #6
Olivier
lgtm
4 years, 1 month ago (2016-11-21 16:16:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512613005/1
4 years, 1 month ago (2016-11-21 17:05:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 19:42:08 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 19:48:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf44e6ae2555a4a3e27562ea1a3d8b266df10458
Cr-Commit-Position: refs/heads/master@{#433609}

Powered by Google App Engine
This is Rietveld 408576698