Cleanup display creation in mus tests.

Cleanup display creation in mus tests.

Create displays via PlatformScreen. DisplayTests will now run the same
code as mustash.

Expand TestPlatformScreen to allow this. It forwards OnDisplayAdded(),
OnDisplayModified() and OnDisplayRemoved() calls. The test is
responsible for making the appropriate calls.

Add new DisplayTests to confirm that creating a display before a WM has
been added works correctly. Also add tests to check that the display
root and WM root ServerWindows are the correct size for a display.

BUG=663907
Committed: https://crrev.com/9298c5ee41f3c4c0078574d72955876ecf8c3b4b
Cr-Commit-Position: refs/heads/master@{#433272}

[kylechar, 2016-11-18 13:34:47]

Description was changed from

==========
Cleanup display creation in mus tests.


BUG=663907
==========

to

==========
Cleanup display creation in mus tests.

Create displays via PlatformScreen. DisplayTests will now run the same
code as mustash.

Expand TestPlatformScreen to allow this. It forwards OnDisplayAdded(),
OnDisplayModified() and OnDisplayRemoved() calls. The test is
responsible for making the appropriate calls.

Add new DisplayTests to confirm that creating a display before a WM has
been added works correctly. Also add tests to check that the display
root and WM root ServerWindows are the correct size for a display.

BUG=663907
==========

[kylechar, 2016-11-18 13:52:32]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-11-18 16:57:40]

LGTM

https://codereview.chromium.org/2512593003/diff/20001/services/ui/ws/test_uti...
File services/ui/ws/test_utils.cc (right):

https://codereview.chromium.org/2512593003/diff/20001/services/ui/ws/test_uti...
services/ui/ws/test_utils.cc:70: int64_t id_;
const if you can.

[kylechar, 2016-11-18 17:27:07]

Thanks sky!

https://codereview.chromium.org/2512593003/diff/20001/services/ui/ws/test_uti...
File services/ui/ws/test_utils.cc (right):

https://codereview.chromium.org/2512593003/diff/20001/services/ui/ws/test_uti...
services/ui/ws/test_utils.cc:70: int64_t id_;
On 2016/11/18 16:57:39, sky wrote:
> const if you can.

Done.

[kylechar, 2016-11-18 17:27:17]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 17:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 19:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 19:22:01]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-11-18 19:28:34]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-11-18 19:28:35]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2512593003/#ps40001
(title: "Make const.")

[commit-bot: I haz the power, 2016-11-18 19:29:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 19:59:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-18 20:04:01]

Description was changed from

==========
Cleanup display creation in mus tests.

Create displays via PlatformScreen. DisplayTests will now run the same
code as mustash.

Expand TestPlatformScreen to allow this. It forwards OnDisplayAdded(),
OnDisplayModified() and OnDisplayRemoved() calls. The test is
responsible for making the appropriate calls.

Add new DisplayTests to confirm that creating a display before a WM has
been added works correctly. Also add tests to check that the display
root and WM root ServerWindows are the correct size for a display.

BUG=663907
==========

to

==========
Cleanup display creation in mus tests.

Create displays via PlatformScreen. DisplayTests will now run the same
code as mustash.

Expand TestPlatformScreen to allow this. It forwards OnDisplayAdded(),
OnDisplayModified() and OnDisplayRemoved() calls. The test is
responsible for making the appropriate calls.

Add new DisplayTests to confirm that creating a display before a WM has
been added works correctly. Also add tests to check that the display
root and WM root ServerWindows are the correct size for a display.

BUG=663907

Committed: https://crrev.com/9298c5ee41f3c4c0078574d72955876ecf8c3b4b
Cr-Commit-Position: refs/heads/master@{#433272}
==========

[commit-bot: I haz the power, 2016-11-18 20:04:02]

Patchset 3 (id:??) landed as
https://crrev.com/9298c5ee41f3c4c0078574d72955876ecf8c3b4b
Cr-Commit-Position: refs/heads/master@{#433272}