Move wtf/BitwiseOperations.h into base/bits.h.

Move wtf/BitwiseOperations.h into base/bits.h.

Part of the plan for WTF, and supports the PartitionAllocator move as well.

BUG=632441
R=dcheng@chromium.org, esprehn@chromium.org

[palmer, 2016-11-17 01:21:41]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 01:22:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[palmer, 2016-11-17 01:25:06]

palmer@chromium.org changed reviewers:
+ dcheng@chromium.org, esprehn@chromium.org

[palmer, 2016-11-17 01:25:44]

dcheng: PTAL base/
esprehn: PTAL third_party/WebKit/Source

Thanks!

[commit-bot: I haz the power, 2016-11-17 03:25:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 03:25:49]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[esprehn, 2016-11-17 07:49:42]

Can we write using X = base::bits or using base::bits instead to avoid the proxy
functions?

https://codereview.chromium.org/2512593002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/BitwiseOperations.h (right):

https://codereview.chromium.org/2512593002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/BitwiseOperations.h:42: return
base::bits::CountLeadingZeroBits32(x);
Can we write

using base::bits instead?

[palmer, 2016-11-17 19:46:41]

> Can we write using X = base::bits or using base::bits instead to avoid the
proxy functions?

Done.

[esprehn, 2016-11-17 19:55:24]

lgtm

[dcheng, 2016-11-17 20:06:25]

base LGTM, with some nits about comments

https://codereview.chromium.org/2512593002/diff/20001/base/bits.h
File base/bits.h (right):

https://codereview.chromium.org/2512593002/diff/20001/base/bits.h#newcode81
base/bits.h:81: // 0, even though these's clearly a return value that makes
sense, and even
these's?

I wonder if this comment meant to write "there's"?

(I know this is an inherited comment)

https://codereview.chromium.org/2512593002/diff/20001/base/bits.h#newcode82
base/bits.h:82: // though nascent processor clz instructions have defined
behaviour for 0.
Not sure if it's still nascent ;-)

[palmer, 2016-11-17 20:18:27]

The CQ bit was checked by palmer@chromium.org

[palmer, 2016-11-17 20:18:27]

https://codereview.chromium.org/2512593002/diff/20001/base/bits.h
File base/bits.h (right):

https://codereview.chromium.org/2512593002/diff/20001/base/bits.h#newcode81
base/bits.h:81: // 0, even though these's clearly a return value that makes
sense, and even
> I wonder if this comment meant to write "there's"?

Done.

https://codereview.chromium.org/2512593002/diff/20001/base/bits.h#newcode82
base/bits.h:82: // though nascent processor clz instructions have defined
behaviour for 0.
> Not sure if it's still nascent ;-)

Done.

[palmer, 2016-11-17 20:18:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2512593002/#ps40001
(title: "Fix comments.")

[commit-bot: I haz the power, 2016-11-17 20:20:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 22:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:35:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[palmer, 2016-11-17 22:42:25]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:44:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 01:46:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 01:46:54]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2016-11-18 21:27:25]

Description was changed from

==========
Move wtf/BitwiseOperations.h into base/bits.h.

Part of the plan for WTF, and supports the PartitionAllocator move as well.

BUG=632441
==========

to

==========
Move wtf/BitwiseOperations.h into base/bits.h.

Part of the plan for WTF, and supports the PartitionAllocator move as well.

BUG=632441
R=dcheng@chromium.org, esprehn@chromium.org

Committed: https://crrev.com/79df70945ad30b96b8579ee2e6943dc6cac3ba19
Cr-Commit-Position: refs/heads/master@{#433301}
==========

[commit-bot: I haz the power, 2016-11-18 21:27:26]

Patchset 4 (id:??) landed as
https://crrev.com/79df70945ad30b96b8579ee2e6943dc6cac3ba19
Cr-Commit-Position: refs/heads/master@{#433301}

[palmer, 2016-11-18 21:30:13]

Description was changed from

==========
Move wtf/BitwiseOperations.h into base/bits.h.

Part of the plan for WTF, and supports the PartitionAllocator move as well.

BUG=632441
R=dcheng@chromium.org, esprehn@chromium.org

Committed: https://crrev.com/79df70945ad30b96b8579ee2e6943dc6cac3ba19
Cr-Commit-Position: refs/heads/master@{#433301}
==========

to

==========
Move wtf/BitwiseOperations.h into base/bits.h.

Part of the plan for WTF, and supports the PartitionAllocator move as well.

BUG=632441
R=dcheng@chromium.org, esprehn@chromium.org
==========

[palmer, 2016-11-18 21:30:15]

Committed patchset #4 (id:60001) to pending queue manually as
6167d66b290bdf880e05bf6ffdefc341079b6d9e (presubmit successful).