Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2512583002: Remove *RowHeightScrollHelper from scroll_view.h/cc (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove *RowHeightScrollHelper from scroll_view.h/cc These classes are not currently in use anywhere. They were part of the initial.commit from 2008 so it's hard to tell why they might have been added originally. BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -143 lines) Patch
M ui/views/controls/scroll_view.h View 1 chunk +0 lines, -70 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 1 chunk +0 lines, -73 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
Evan Stade
4 years, 1 month ago (2016-11-17 18:11:56 UTC) #7
sky
These were used to handle scrolling by lines. I actually think we should keep this ...
4 years, 1 month ago (2016-11-17 20:08:58 UTC) #11
Evan Stade
4 years, 1 month ago (2016-11-17 21:13:49 UTC) #12
ok, filed bug 666464. Closing this CL.

Powered by Google App Engine
This is Rietveld 408576698