Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2512573003: [Android] Fix toolbar jumping in after returning to Chrome. (Closed)

Created:
4 years, 1 month ago by Ted C
Modified:
4 years, 1 month ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix toolbar jumping in after returning to Chrome. The fix is two fold: 1.) Previously, it was being too aggressive about showing the controls based on any tab model event. It should only do this if the tab changed. 2.) The transient show request on activity resumption was fighting with Android's activity animation, so this introduces a delay to make it look pretty. BUG=666443 Committed: https://crrev.com/d1e53e302cbb06925cbab1c0fec36dcf56ca33b8 Cr-Commit-Position: refs/heads/master@{#433043}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Ted C
PTAL
4 years, 1 month ago (2016-11-17 20:11:36 UTC) #2
mdjones
lgtm
4 years, 1 month ago (2016-11-17 21:45:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512573003/1
4 years, 1 month ago (2016-11-17 21:49:44 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
4 years, 1 month ago (2016-11-17 23:36:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512573003/20001
4 years, 1 month ago (2016-11-17 23:43:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-18 01:46:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2512573003/20001
4 years, 1 month ago (2016-11-18 01:52:57 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 03:09:31 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 03:13:39 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1e53e302cbb06925cbab1c0fec36dcf56ca33b8
Cr-Commit-Position: refs/heads/master@{#433043}

Powered by Google App Engine
This is Rietveld 408576698