Add GetIsPinnedToTaskbarState()

chrome/browser/ui/webui/welcome_win10_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/welcome_win10_handler.h"
 
 #include "base/bind.h"
-#include "base/memory/ptr_util.h"
+#include "base/values.h"
 #include "chrome/browser/shell_integration.h"
+#include "chrome/browser/shell_integration_win.h"
 #include "chrome/common/url_constants.h"
-#include "chrome/grit/generated_resources.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/web_contents.h"
-#include "ui/base/l10n/l10n_util.h"
 #include "url/gurl.h"
 
-WelcomeWin10Handler::WelcomeWin10Handler() {
+WelcomeWin10Handler::WelcomeWin10Handler() : weak_ptr_factory_(this) {
   // The check is started as early as possible because waiting for the page to
   // be fully loaded is unnecessarily wasting time.
   StartIsPinnedToTaskbarCheck();
 }
 
 WelcomeWin10Handler::~WelcomeWin10Handler() = default;
 
 void WelcomeWin10Handler::RegisterMessages() {
   web_ui()->RegisterMessageCallback(
       "handleSetDefaultBrowser",
@@ skipping 40 matching lines @@
       ->StartSetAsDefault();
 }
 
 void WelcomeWin10Handler::HandleContinue(const base::ListValue* args) {
   web_ui()->GetWebContents()->GetController().LoadURL(
       GURL(chrome::kChromeUINewTabURL), content::Referrer(),
       ui::PageTransition::PAGE_TRANSITION_LINK, std::string());
 }
 
 void WelcomeWin10Handler::StartIsPinnedToTaskbarCheck() {
-  // Start the utility process that will handle the IsPinnedToTaskbar() call.
-  client_ =
-      base::MakeUnique<content::UtilityProcessMojoClient<mojom::ShellHandler>>(
-          l10n_util::GetStringUTF16(IDS_UTILITY_PROCESS_SHELL_HANDLER_NAME));
+  // Assume that Chrome is pinned to the taskbar if an error occurs.
+  base::Closure error_callback =
+      base::Bind(&WelcomeWin10Handler::OnIsPinnedToTaskbarDetermined,
+                 weak_ptr_factory_.GetWeakPtr(), true);
 
-  // Assume that Chrome is pinned to the taskbar if an error occurs.
-  client_->set_error_callback(
-      base::Bind(&WelcomeWin10Handler::OnIsPinnedToTaskbarDetermined,
-                 base::Unretained(this), true));
-  client_->set_disable_sandbox();
-  client_->Start();
-
-  client_->service()->IsPinnedToTaskbar(base::Bind(
-      &WelcomeWin10Handler::OnIsPinnedToTaskbarResult, base::Unretained(this)));
+  shell_integration::win::GetIsPinnedToTaskbarState(
+      error_callback,
+      base::Bind(&WelcomeWin10Handler::OnIsPinnedToTaskbarResult,
+                 weak_ptr_factory_.GetWeakPtr()));
 }
 
 void WelcomeWin10Handler::OnIsPinnedToTaskbarResult(bool succeeded,
                                                     bool is_pinned_to_taskbar) {
   OnIsPinnedToTaskbarDetermined(succeeded && is_pinned_to_taskbar);

[grt (UTC plus 2), 2016/11/21 10:45:31]

should this be !succeeded || is_pinned_to_taskbar for consistency with the way
connection errors are handled above? if not, please explain in a comment either
here or up on line 77 (or both!).

[Patrick Monette, 2016/11/21 18:48:47]

Good catch. Done.

 }
 
 void WelcomeWin10Handler::OnIsPinnedToTaskbarDetermined(
     bool is_pinned_to_taskbar) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
-  // Reset the client and the timer to make sure this function only gets called
-  // once.
-  client_.reset();
+  // Early exit if the pinned_state was already determined.
+  if (pinned_state_result_)
+    return;
+
+  // Stop the timer if it's still running.
   timer_.Stop();
 
   pinned_state_result_ = is_pinned_to_taskbar;
 
   // If the page already called getPinnedToTaskbarState(), the result can be
   // sent back.
   if (!pinned_state_callback_id_.empty())
     SendPinnedToTaskbarStateResult();
 }
 
 void WelcomeWin10Handler::SendPinnedToTaskbarStateResult() {
   ResolveJavascriptCallback(
       base::StringValue(pinned_state_callback_id_),
       base::FundamentalValue(pinned_state_result_.value()));
 }